clean up map

GoogleCloudPlatform · Aug 14, 2020 · cd2fc5d · cd2fc5d
1 parent 40b312d
commit cd2fc5d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/templates/terraform/constants/bigquery_dataset_access.go.erb b/templates/terraform/constants/bigquery_dataset_access.go.erb
@@ -4,19 +4,6 @@ var bigqueryAccessRoleToPrimitiveMap =  map[string]string {
     "roles/bigquery.dataViewer": "READER",
 }
 
-var bigqueryAccessIamMemberToTypeMap = map[string]string{
-	"serviceAccount":        "user_by_email",
-	"user":                  "user_by_email",
-	"group":                 "group_by_email",
-	"domain":                "domain",
-	"specialGroup":          "special_group",
-	"allUsers":              "iam_member",
-	"projectOwners":         "special_group",
-	"projectReaders":        "special_group",
-	"projectWriters":        "special_group",
-	"allAuthenticatedUsers": "special_group",
-}
-
 func resourceBigQueryDatasetAccessRoleDiffSuppress(k, old, new string, d *schema.ResourceData) bool {
     if primitiveRole, ok := bigqueryAccessRoleToPrimitiveMap[new]; ok {
         return primitiveRole == old

diff --git a/templates/terraform/post_create/bigquery_dataset_access.go.erb b/templates/terraform/post_create/bigquery_dataset_access.go.erb
@@ -18,7 +18,7 @@ d.Set("api_updated_member", false)
 
 // iam_member is a generalized attribute, if the API can map it to a different member type on the backend, it will return
 // the correct member_type in the response. If it cannot be mapped to a different member type, it will stay in iam_member.
-if d.Get("iam_member") != nil {
+if iamMemberProp != "" {
 	member_type, member, err := resourceBigQueryDatasetAccessReassignIamMemberInNestedObjectList(d, meta, res["access"].([]interface{}))
 	if err != nil {
 		fmt.Println(err)