remove validation and update version 3 upgrade doc

GoogleCloudPlatform · Oct 22, 2019 · adac7d8 · adac7d8
1 parent 9856689
commit adac7d8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/third_party/terraform/resources/resource_cloudfunctions_function.go b/third_party/terraform/resources/resource_cloudfunctions_function.go
@@ -191,7 +191,6 @@ func resourceCloudFunctionsFunction() *schema.Resource {
 			"runtime": {
 				Type:         schema.TypeString,
 				Required:     true,
-				ValidateFunc: validation.StringInSlice([]string{"nodejs8", "nodejs10", "python37", "go111"}, false),
 			},
 
 			"service_account_email": {

diff --git a/third_party/terraform/website/docs/r/cloudfunctions_function.html.markdown b/third_party/terraform/website/docs/r/cloudfunctions_function.html.markdown
@@ -105,8 +105,8 @@ The following arguments are supported:
 
 * `name` - (Required) A user-defined name of the function. Function names must be unique globally.
 
-* `runtime` - (Required) The runtime in which the function is going to run. One
-of `"nodejs8"`, `"nodejs10"`, `"python37"`, `"go111"`.
+* `runtime` - (Required) The runtime in which the function is going to run.
+Eg. `"nodejs8"`, `"nodejs10"`, `"python37"`, `"go111"`.
 
 - - -
 

diff --git a/third_party/terraform/website/docs/version_3_upgrade.html.markdown b/third_party/terraform/website/docs/version_3_upgrade.html.markdown
@@ -53,6 +53,7 @@ so Terraform knows to manage them.
 
 - [Provider Version Configuration](#provider-version-configuration)
 - [Data Source: `google_container_engine_versions`](#data-source-google_container_engine_versions)
+- [Resource: `google_cloudfunctions_function`](#resource-google_cloudfunctions_function)
 - [Resource: `google_cloudiot_registry`](#resource-google_cloudiot_registry)
 - [Resource: `google_compute_forwarding_rule`](#resource-google_compute_forwarding_rule)
 - [Resource: `google_compute_network`](#resource-google_compute_network)
@@ -109,6 +110,13 @@ provider "google" {
 
 Use `location` instead.
 
+## Resource: `google_cloudfunctions_function`
+
+### The `runtime` option `nodejs6` has been deprecated
+
+`nodejs6` has been deprecated and is no longer the default value for `runtime`.
+`runtime` is now required.
+
 ## Resource: `google_cloudiot_registry`
 
 ### `event_notification_config` is now removed