Add tests for healthcare store pubsub topic removal (#3122)

* Add tests for healthcare store pubsub topic removal. * Address code review comments.
GoogleCloudPlatform · Feb 13, 2020 · abcd9f9 · abcd9f9
1 parent 9d8ea2d
commit abcd9f9
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 6 deletions.
diff --git a/third_party/terraform/tests/resource_healthcare_dicom_store_test.go.erb b/third_party/terraform/tests/resource_healthcare_dicom_store_test.go.erb
@@ -3,12 +3,13 @@ package google
 <% unless version == 'ga' -%>
 import (
 	"fmt"
-	"github.com/hashicorp/terraform-plugin-sdk/helper/acctest"
-	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
-	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 	"path"
 	"strings"
 	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/helper/acctest"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
 func TestAccHealthcareDicomStoreIdParsing(t *testing.T) {
@@ -103,6 +104,15 @@ func TestAccHealthcareDicomStore_basic(t *testing.T) {
 				ImportState:       true,
 				ImportStateVerify: true,
 			},
+			// TODO(b/148536607): Uncomment once b/148536607 is fixed.
+			// {
+			// 	Config: testGoogleHealthcareDicomStore_basic(dicomStoreName, datasetName),
+			// },
+			// {
+			// 	ResourceName:      resourceName,
+			// 	ImportState:       true,
+			// 	ImportStateVerify: true,
+			// },
 		},
 	})
 }

diff --git a/third_party/terraform/tests/resource_healthcare_fhir_store_test.go.erb b/third_party/terraform/tests/resource_healthcare_fhir_store_test.go.erb
@@ -104,6 +104,14 @@ func TestAccHealthcareFhirStore_basic(t *testing.T) {
 				ImportState:       true,
 				ImportStateVerify: true,
 			},
+			{
+				Config: testGoogleHealthcareFhirStore_basic(fhirStoreName, datasetName),
+			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
 		},
 	})
 }

diff --git a/third_party/terraform/tests/resource_healthcare_hl7_v2_store_test.go.erb b/third_party/terraform/tests/resource_healthcare_hl7_v2_store_test.go.erb
@@ -3,12 +3,13 @@ package google
 <% unless version == 'ga' -%>
 import (
 	"fmt"
-	"github.com/hashicorp/terraform-plugin-sdk/helper/acctest"
-	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
-	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 	"path"
 	"strings"
 	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/helper/acctest"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
 func TestAccHealthcareHl7V2StoreIdParsing(t *testing.T) {
@@ -103,6 +104,14 @@ func TestAccHealthcareHl7V2Store_basic(t *testing.T) {
 				ImportState:       true,
 				ImportStateVerify: true,
 			},
+			{
+				Config: testGoogleHealthcareHl7V2Store_basic(hl7_v2StoreName, datasetName),
+			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
 		},
 	})
 }