Update how we create triggers to enable non-main branches to be teste…

…d on schedules

mmv1/third_party/terraform/.teamcity/components/builds/build_triggers.kt

@@ -18,15 +18,15 @@ class NightlyTriggerConfiguration(
     val nightlyTestsEnabled: Boolean = true,
     val startHour: Int = DefaultStartHour,
     val daysOfWeek: String = DefaultDaysOfWeek,
-    val daysOfMonth: String = DefaultDaysOfMonth
+    val daysOfMonth: String = DefaultDaysOfMonth,
+    val filter: String = "+:refs/heads/main"
 )
 
 fun Triggers.runNightly(config: NightlyTriggerConfiguration) {
-    val filter = "+:refs/heads/main"
 
     schedule{
         enabled = config.nightlyTestsEnabled
-        branchFilter = filter
+        branchFilter = config.filter
         triggerBuild = always() // Run build even if no new commits/pending changes
         withPendingChangesOnly = false
         enforceCleanCheckout = true

mmv1/third_party/terraform/.teamcity/components/projects/feature_branches/FEATURE-BRANCH-provider-functions.kt

@@ -43,7 +43,10 @@ fun featureBranchProviderFunctionSubProject(allConfig: AllContextParameters): Pr
     val packageName = "functions" // This project will contain only builds to test this single package
     val sharedResourcesEmpty: List<String> = listOf() // No locking when testing functions
     val vcrConfig = getVcrAcceptanceTestConfig(allConfig) // Reused below for both MM testing build configs
-    val trigger  = NightlyTriggerConfiguration() // Resued below for running tests against the downstream repos every night.
+
+    // Trigger reused below for running tests against the downstream repos every night.
+    // Need to supply non-default branch filter
+    val trigger  = NightlyTriggerConfiguration(filter="+:refs/heads/$featureBranchProviderFunctionsName") 
 
     var parentId: String // To be overwritten when each build config is generated below.