Make GOOGLE_CHRONICLE_INSTANCE_ID optional for magician code

GoogleCloudPlatform · Dec 17, 2024 · 9c3df70 · 9c3df70
1 parent dfa39bd
commit 9c3df70
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/.ci/magician/cmd/check_cassettes.go b/.ci/magician/cmd/check_cassettes.go
@@ -16,7 +16,6 @@ var ccRequiredEnvironmentVariables = [...]string{
 	"GOCACHE",
 	"GOPATH",
 	"GOOGLE_BILLING_ACCOUNT",
-	"GOOGLE_CHRONICLE_INSTANCE_ID",
 	"GOOGLE_CUST_ID",
 	"GOOGLE_IDENTITY_USER",
 	"GOOGLE_MASTER_BILLING_ACCOUNT",
@@ -33,7 +32,9 @@ var ccRequiredEnvironmentVariables = [...]string{
 	"SA_KEY",
 }
 
-var ccOptionalEnvironmentVariables = [...]string{}
+var ccOptionalEnvironmentVariables = [...]string{
+	"GOOGLE_CHRONICLE_INSTANCE_ID",
+}
 
 var checkCassettesCmd = &cobra.Command{
 	Use:   "check-cassettes",

diff --git a/.ci/magician/cmd/test_terraform_vcr.go b/.ci/magician/cmd/test_terraform_vcr.go
@@ -37,7 +37,6 @@ var ttvRequiredEnvironmentVariables = [...]string{
 	"GOCACHE",
 	"GOPATH",
 	"GOOGLE_BILLING_ACCOUNT",
-	"GOOGLE_CHRONICLE_INSTANCE_ID",
 	"GOOGLE_CUST_ID",
 	"GOOGLE_IDENTITY_USER",
 	"GOOGLE_MASTER_BILLING_ACCOUNT",
@@ -56,7 +55,9 @@ var ttvRequiredEnvironmentVariables = [...]string{
 	"USER",
 }
 
-var ttvOptionalEnvironmentVariables = [...]string{}
+var ttvOptionalEnvironmentVariables = [...]string{
+	"GOOGLE_CHRONICLE_INSTANCE_ID",
+}
 
 type analytics struct {
 	ReplayingResult  vcr.Result

diff --git a/.ci/magician/cmd/vcr_cassette_update.go b/.ci/magician/cmd/vcr_cassette_update.go
@@ -19,7 +19,6 @@ var vcuRequiredEnvironmentVariables = [...]string{
 	"GOCACHE",
 	"GOPATH",
 	"GOOGLE_BILLING_ACCOUNT",
-	"GOOGLE_CHRONICLE_INSTANCE_ID",
 	"GOOGLE_CUST_ID",
 	"GOOGLE_IDENTITY_USER",
 	"GOOGLE_MASTER_BILLING_ACCOUNT",
@@ -39,7 +38,9 @@ var vcuRequiredEnvironmentVariables = [...]string{
 	"GITHUB_TOKEN_CLASSIC",
 }
 
-var vcuOptionalEnvironmentVariables = [...]string{}
+var vcuOptionalEnvironmentVariables = [...]string{
+	"GOOGLE_CHRONICLE_INSTANCE_ID",
+}
 
 var (
 	//go:embed templates/vcr/vcr_cassettes_update_replaying.tmpl