Mark labels as deprecated (#4039)

GoogleCloudPlatform · Oct 1, 2020 · 49de8cd · 49de8cd
1 parent ca50e52
commit 49de8cd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/third_party/terraform/resources/resource_dataflow_flex_template_job.go.erb b/third_party/terraform/resources/resource_dataflow_flex_template_job.go.erb
@@ -61,6 +61,8 @@ func resourceDataflowFlexTemplateJob() *schema.Resource {
 				Optional:         true,
 				DiffSuppressFunc: resourceDataflowJobLabelDiffSuppress,
 				ForceNew:         true,
+				// TODO add support for labels when the API supports it
+				Deprecated:       "Deprecated until the API supports this field",
 			},
 
 			"parameters": {

diff --git a/third_party/terraform/website/docs/r/dataflow_flex_template_job.html.markdown b/third_party/terraform/website/docs/r/dataflow_flex_template_job.html.markdown
@@ -64,7 +64,9 @@ used in the template).
 
 * `labels` - (Optional) User labels to be specified for the job. Keys and values
 should follow the restrictions specified in the [labeling restrictions](https://cloud.google.com/compute/docs/labeling-resources#restrictions)
-page. **NOTE**: Google-provided Dataflow templates often provide default labels
+page. **Note**: This field is marked as deprecated in Terraform as the API does not currently
+support adding labels. 
+**NOTE**: Google-provided Dataflow templates often provide default labels
 that begin with `goog-dataflow-provided`. Unless explicitly set in config, these
 labels will be ignored to prevent diffs on re-apply.