Skip to content

Commit

Permalink
Ignore failing tests for AppEngine and IAP (#11396)
Browse files Browse the repository at this point in the history
  • Loading branch information
slevenick authored Aug 8, 2024
1 parent d043ef4 commit 24de582
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 2 deletions.
2 changes: 2 additions & 0 deletions mmv1/products/appengine/FlexibleAppVersion.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ examples:
- !ruby/object:Provider::Terraform::Examples
name: 'app_engine_flexible_app_version'
primary_resource_id: 'myapp_v1'
# https://github.com/hashicorp/terraform-provider-google/issues/19040
skip_test: true
ignore_read_extra:
- 'noop_on_destroy'
- 'deployment.0.zip'
Expand Down
2 changes: 2 additions & 0 deletions mmv1/products/iap/AppEngineService.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ examples:
name: 'iap_app_engine_service'
primary_resource_id: 'version'
primary_resource_name: 'context["project_id"], "default"'
# https://github.com/hashicorp/terraform-provider-google/issues/18936
skip_test: true
test_env_vars:
org_id: :ORG_ID
billing_account: :BILLING_ACCT
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,18 @@ package appengine_test
<% unless version == 'ga' -%>

import (
"testing"
"log"
"strings"
"testing"

"github.com/hashicorp/terraform-plugin-testing/helper/resource"
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
"github.com/hashicorp/terraform-plugin-testing/terraform"
"github.com/hashicorp/terraform-provider-google/google/acctest"
"github.com/hashicorp/terraform-provider-google/google/envvar"
)

func TestAccAppEngineFlexibleAppVersion_update(t *testing.T) {
t.Skip("https://github.com/hashicorp/terraform-provider-google/issues/18239")
t.Parallel()

context := map[string]interface{}{
Expand Down Expand Up @@ -419,4 +423,22 @@ resource "google_storage_bucket_object" "main" {
}`, context)
}

// Remove when generated test is enabled
func testAccCheckAppEngineFlexibleAppVersionDestroyProducer(t *testing.T) func(s *terraform.State) error {
return func(s *terraform.State) error {
for name, rs := range s.RootModule().Resources {
if rs.Type != "google_app_engine_flexible_app_version" {
continue
}
if strings.HasPrefix(name, "data.") {
continue
}

log.Printf("[DEBUG] Ignoring destroy during test")
}

return nil
}
}

<% end -%>
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
)

func TestAccAppEngineStandardAppVersion_update(t *testing.T) {
t.Skip("https://github.com/hashicorp/terraform-provider-google/issues/18936")
t.Parallel()

context := map[string]interface{}{
Expand Down

0 comments on commit 24de582

Please sign in to comment.