Patch the change to send SdkPipeline parameters via environment fields in DataflowFlexTemplateJob #905
+644
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TemplateJob is always 0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maqiuyujoyce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jingyih
reviewed
Oct 11, 2023
|
@jingyih Done! |
…s in DataflowFlexTemplateJob
maqiuyujoyce
changed the title
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Fixes b/304563477
Added a patch to send SdkPipeline parameters via environment block fields and to fix the issue that the retrieved maxWorkers was always 0.
The patch is identical with the fix in TF: GoogleCloudPlatform/magic-modules#9031
Tests you have done
make ready-prto ensure this PR is ready for review.Created a streaming job using the DataflowFlexTemplateJob on a locally built KCC and the resource status became UpToDate and stayed to be UpToDate.