fix: Make ResourceID field "mutable"

[jasonvigil]

In practice, due to in-controller enforcement, the only valid change is to set from empty string -> actual resource ID.

[maqiuyujoyce]

Could you also remove the Immutable. from the field description?

[jasonvigil]

Could you also remove the Immutable. from the field description?

I think it is sort of "correct" to include the immutable in the field description. The only valid change is from empty string -> actual resource id. Otherwise it is immutable.

[jasonvigil]

Could you also remove the Immutable. from the field description?

I think it is sort of "correct" to include the immutable in the field description. The only valid change is from empty string -> actual resource id. Otherwise it is immutable.

Though, maybe since it is removed from the template, we should remove from existing also. Will do.

[maqiuyujoyce]

I think "Immutable" is a very specific concept. Something like Must be the same resource ID once successfully reconciled may be helpful?

[yuwenma]

/lgtm
/approve

Thanks!

[yuwenma]

/lgtm

[maqiuyujoyce]

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maqiuyujoyce, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maqiuyujoyce,yuwenma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jasonvigil]

I think "Immutable" is a very specific concept. Something like Must be the same resource ID once successfully reconciled may be helpful?

Agreed it will be helpful to add some comment to help users understand the validation behavior. Just added (for template and all resources)

[maqiuyujoyce]

/lgtm