WIP: DiscoveryEngineDataStoreTargetSite: mockgcp #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
justinsb
commented
Dec 19, 2024
justinsb
commented
- DiscoveryEngineTargetSite: initial types
- DiscoveryEngineTargetSite: generated apimachinery
- DiscoveryEngineDataStoreTargetSite: create test
- tests: golden output
- Fixes to API (should go into previous PR)
- Autogen fixes (should go into previous PR)
- tests: normalization for DiscoveryEngineDataStoreTargetSite
- DiscoveryStoreDataStoreTargetSite: controller
- chore: create shared project number/id mapper
- DiscoveryEngineDataStoreTargetSite: mockgcp support
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
changed the title
justinsb
force-pushed
the
discoveryenginedatastoretargetsite_mockgcp
branch
from
f33fbbf to
abb9174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.