Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: DiscoveryEngineDataStoreTargetSite controller & tests #3425

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

justinsb
Copy link
Collaborator

  • DiscoveryEngineTargetSite: initial types
  • DiscoveryEngineTargetSite: generated apimachinery
  • DiscoveryEngineDataStoreTargetSite: create test
  • tests: golden output
  • Fixes to API (should go into previous PR)
  • Autogen fixes (should go into previous PR)
  • tests: normalization for DiscoveryEngineDataStoreTargetSite
  • DiscoveryStoreDataStoreTargetSite: controller
  • chore: create shared project number/id mapper
  • DiscoveryEngineDataStoreTargetSite: mockgcp support

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb justinsb force-pushed the discoveryenginedatastoretargetsite_controller branch from f33fbbf to 561ba16 Compare December 19, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant