Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PrivateConfig field to SecureSourceManagerInstance #3419

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

ericpang777
Copy link
Contributor

@ericpang777 ericpang777 commented Dec 18, 2024

Change description

Adds the PrivateConfig field to the controller

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maqiuyujoyce for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ericpang777 ericpang777 marked this pull request as ready for review December 18, 2024 21:22
@ericpang777
Copy link
Contributor Author

Branched off #3238

@yuwenma Is it okay to let this through despite the example not working in real gcp due to a limitation of the KCC PrivateCACertificateAuthority? The KCC PrivateCACertificateAuthority doesn't enable the CA for some reason, but if you enable it manually, this example would work, so it's not an issue with the logic of SSM.

@ericpang777 ericpang777 force-pushed the ssmins-private-example2 branch from c9fcb65 to 9c02a94 Compare December 18, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant