-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PrivateConfig field to SecureSourceManagerInstance #3419
base: master
Are you sure you want to change the base?
Add PrivateConfig field to SecureSourceManagerInstance #3419
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Branched off #3238 @yuwenma Is it okay to let this through despite the example not working in real gcp due to a limitation of the KCC PrivateCACertificateAuthority? The KCC PrivateCACertificateAuthority doesn't enable the CA for some reason, but if you enable it manually, this example would work, so it's not an issue with the logic of SSM. |
c9fcb65
to
9c02a94
Compare
Change description
Adds the PrivateConfig field to the controller
Tests you have done
make ready-pr
to ensure this PR is ready for review.