feat: Add fuzzer for WorkstationConfig #3410
Conversation
|
One question about trigging the fuzz test. |
| @@ -127,8 +127,6 @@ func WorkstationConfigSpec_ToProto(mapCtx *direct.MapContext, in *krm.Workstatio | |||
| out.ReadinessChecks = direct.Slice_ToProto(mapCtx, in.ReadinessChecks, WorkstationConfig_ReadinessCheck_ToProto) | |||
| out.ReplicaZones = in.ReplicaZones | |||
|
|
|||
| ApplyWorkstationConfigGCPDefaults(mapCtx, in, out, actual) | |||
There was a problem hiding this comment.
This is the right place to set the default. Can I ask why we move it to the CRUD ?
There was a problem hiding this comment.
This had to be moved out so that the mapping function would satisfy the interface required by the fuzz tests. Applying the defaults requires passing in the actual WorkstationConfig proto.
| @@ -39,6 +40,40 @@ import ( | |||
|
|
|||
| func init() { | |||
| registry.RegisterModel(krm.WorkstationConfigGVK, NewWorkstationConfigModel) | |||
| fuzztesting.RegisterKRMFuzzer(workstationConfigFuzzer()) | |||
There was a problem hiding this comment.
Just notice this, could you elaborate how to run this fuzz test if add the init here but not this file?
There was a problem hiding this comment.
This seems to be a new(er) method for setting up fuzz tests. I think it's a bit easier to use. The tests are run here
, or manually withgo test -v ./pkg/fuzztesting/fuzztests/ -fuzz=FuzzAllMappers -fuzztime 60s
There was a problem hiding this comment.
Yeah I believe we have a new framework for fuzzers now. "find-missing-fields" is probably deprecated.
@acpana do we have plan to migrate old-styled fuzz tests and remove the deprecated files to avoid confusion?
jasonvigil
force-pushed
the
workstationconfig-fuzzer
branch
from
e6f3571 to
f4c959d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit b410df0
into
GoogleCloudPlatform:master
No description provided.