fix: add shortnames #3408
Merged
fix: add shortnames #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold I want to coordinate the merge with #3407 |
acpana
force-pushed
the
acpana/fix-shortnames
branch
from
896de70 to
76e2219
Compare
yuwenma
reviewed
Dec 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
acpana
force-pushed
the
acpana/fix-shortnames
branch
from
76e2219 to
6b46842
Compare
acpana
force-pushed
the
acpana/fix-shortnames
branch
from
6b46842 to
78f4c59
Compare
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
acpana
force-pushed
the
acpana/fix-shortnames
branch
from
78f4c59 to
5d2eaca
Compare
|
/hold cancel |
|
/lgtm |
google-oss-prow
bot
merged commit 9611dfc
into
GoogleCloudPlatform:master
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For listing.