Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: new new new ref style #3403

Merged

Conversation

acpana
Copy link
Collaborator

@acpana acpana commented Dec 17, 2024

Small refactor to have the (direct) BigQueryDataset use the new (x3) reference style. This PR doesn't change anything under apis/refs/ yet. NOTE: BigQueryDataset is not yet a converted resource -- it's still a TF resource.

Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acpana acpana force-pushed the acpana/fix-bigquerydataset2 branch from 0a9cdc3 to ace6842 Compare December 18, 2024 20:50
@google-oss-prow google-oss-prow bot removed the lgtm label Dec 18, 2024
@acpana acpana requested a review from yuwenma December 18, 2024 20:50
@acpana acpana force-pushed the acpana/fix-bigquerydataset2 branch from ace6842 to cbaf363 Compare December 18, 2024 22:51
@yuwenma
Copy link
Collaborator

yuwenma commented Dec 19, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 19, 2024
@google-oss-prow google-oss-prow bot merged commit 7f71536 into GoogleCloudPlatform:master Dec 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants