tool: add update-types sync command to synchronize go types with proto definitions
#3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jingyih
force-pushed
the
type_updater_sync_tool
branch
2 times, most recently
from
967b9e4 to
00988c1
Compare
jingyih
changed the title
update-types sync command to synchronize Go types with proto definitions
jingyih
changed the title
update-types sync command to synchronize Go types with proto definitionsupdate-types sync command to synchronize go types with proto definitions
jingyih
commented
Dec 18, 2024
| schedule. This field supports existing time-based and manual transfer | ||
| schedule. Also supports Event-Driven transfer schedule. ScheduleOptionsV2 | ||
| cannot be used together with ScheduleOptions/Schedule. | ||
| description: Options customizing different types of data transfer |
There was a problem hiding this comment.
I previously added the scheduleOptionsV2 field manually using the field comments from [1]. However, the correct field comments is [2]. Only a slight difference between the two.
jingyih
force-pushed
the
type_updater_sync_tool
branch
from
31cd34f to
16f0059
Compare
|
Rebased to pick up the fix for the broken HEAD. |
Add a new command 'update-types sync' that synchronizes existing Go types with their proto definitions. This ensures that Go field types and comments stay in sync with the proto definitions while preserving: - Special annotations (e.g. +required) - Reference fields - Ignored fields - Manual edits
go run . update-types sync \
--service google.cloud.bigquery.datatransfer.v1 \
--api-version bigquerydatatransfer.cnrm.cloud.google.com/v1beta1 \
--legacy-mode
${REPO_ROOT}/dev/tasks/fix-gofmt
jingyih
force-pushed
the
type_updater_sync_tool
branch
from
16f0059 to
6973b19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new command
update-types syncthat synchronizes existing Go types with corresponding proto definitions (at the pinned version). This ensures that Go field types and comments stay in sync with the proto definitions while preserving:// +required,// +kubebuilder:xxx)Example usage
Use the
--legacy-modeflag for resources that were previously generated with KRM fields without the// +kcc:protoannotations.