-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the spec.configmanagement.configSync.stopSyncing
field in GKEHubFeatureMembership
#3399
Support the spec.configmanagement.configSync.stopSyncing
field in GKEHubFeatureMembership
#3399
Conversation
…KEHubFeatureMembership
/cc @ziyue-101 |
/assign @acpana |
/lgtm leave approval to @acpana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks! Assigned to @acpana for another pass for GKEHub resources.
/hold |
@yuwenma , I saw you put the PR on hold. Are there any action items for me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks for the change 🥇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acpana, yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
cd58b1e
into
GoogleCloudPlatform:master
Change description
This adds the support for the
spec.configmanagement.configSync.stopSyncing
field into the resourceGKEHubFeatureMembership
.This PR needs a release note.
Tests you have done
make ready-pr
to ensure this PR is ready for review.