Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the spec.configmanagement.configSync.stopSyncing field in GKEHubFeatureMembership #3399

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

haiyanmeng
Copy link
Contributor

Change description

This adds the support for the spec.configmanagement.configSync.stopSyncing field into the resource GKEHubFeatureMembership.

This PR needs a release note.

Tests you have done

E2E_KUBE_TARGET=envtest RUN_E2E=1 E2E_GCP_TARGET=mock WRITE_GOLDEN_OUTPUT=1 GOLDEN_REQUEST_CHECKS=1 GOLDEN_OBJECT_CHECKS=1 go test -test.count=1 -timeout 1000s -v ./tests/e2e -run 'TestAllInSeries/fixtures/gkehubfeaturemembership|TestAllInSeries/fixtures/gkehubfeaturemembership'
  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@haiyanmeng
Copy link
Contributor Author

/cc @ziyue-101

@google-oss-prow google-oss-prow bot requested a review from ziyue-101 December 17, 2024 19:46
@haiyanmeng
Copy link
Contributor Author

/assign @acpana

@ziyue-101
Copy link
Collaborator

/lgtm

leave approval to @acpana

Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks! Assigned to @acpana for another pass for GKEHub resources.

@yuwenma
Copy link
Collaborator

yuwenma commented Dec 17, 2024

/hold

@haiyanmeng
Copy link
Contributor Author

@yuwenma , I saw you put the PR on hold. Are there any action items for me?

@yuwenma
Copy link
Collaborator

yuwenma commented Dec 18, 2024

@yuwenma , I saw you put the PR on hold. Are there any action items for me?

No action items. I just want to make sure @acpana can take a look before it merges.

Copy link
Collaborator

@acpana acpana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks for the change 🥇

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acpana, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acpana
Copy link
Collaborator

acpana commented Dec 19, 2024

/hold cancel

@google-oss-prow google-oss-prow bot merged commit cd58b1e into GoogleCloudPlatform:master Dec 19, 2024
16 of 17 checks passed
@haiyanmeng haiyanmeng deleted the stop-syncing branch December 19, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants