Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] HTTP log against real GCP API using direct controller for AlloyDBInstance #3361

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maqiuyujoyce
Copy link
Collaborator

@maqiuyujoyce maqiuyujoyce commented Dec 11, 2024

This PR is used to track test result and should not be merged.

Test log changes can be found in cd66b14. All the diffs in HTTP events against the AlloyDBInstance look reasonable.

  1. All the dependent resources in test cases are fixed and are abandoned and required to save test time.
  2. All the enum values in HTTP logs are now integers instead of strings.
  3. Non-pointer bool fields in the requests in HTTP logs are captured with their default values, false.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maqiuyujoyce. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant