Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mockgcp: improve ComputeServiceAttachment fidelity / testing #3247

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

justinsb
Copy link
Collaborator

  • tests: create project on fly
  • tests: add golden output for computeserviceattachment
  • mockgcp: improve ComputeServiceAttachment fidelity

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a vague memory that the project-id annotation has to use some specific variable value otherwise the postsubmit dynamic test will fail... 😞

@yuwenma
Copy link
Collaborator

yuwenma commented Nov 25, 2024

I have a vague memory that the project-id annotation has to use some specific variable value otherwise the postsubmit dynamic test will fail... 😞

Here it is

TestDependentOrgProjectID = EnvVar{Key: "TEST_DEPENDENT_ORG_PROJECT_ID"}

@justinsb justinsb force-pushed the mockgcp_computeserviceattachment branch from 865b7a3 to bcec9bd Compare November 25, 2024 19:13
@justinsb justinsb force-pushed the mockgcp_computeserviceattachment branch from bcec9bd to aeb7e1f Compare December 17, 2024 19:21
Looks like we can just create this project,
rather than using TEST_DEPENDENDENT_ORG_PROJECT_ID
@justinsb justinsb force-pushed the mockgcp_computeserviceattachment branch from aeb7e1f to 4c4aa81 Compare December 18, 2024 17:16
@justinsb
Copy link
Collaborator Author

I have a vague memory that the project-id annotation has to use some specific variable value otherwise the postsubmit dynamic test will fail... 😞

Well let's try it and fix that if need be :-)

A few tweaks that get the ComputeServiceAttachment test lining up
(even if the results aren't exact yet).
@justinsb justinsb force-pushed the mockgcp_computeserviceattachment branch from 4c4aa81 to 3423fe9 Compare December 18, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants