-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mockgcp: improve ComputeServiceAttachment fidelity / testing #3247
base: master
Are you sure you want to change the base?
mockgcp: improve ComputeServiceAttachment fidelity / testing #3247
Conversation
justinsb
commented
Nov 23, 2024
- tests: create project on fly
- tests: add golden output for computeserviceattachment
- mockgcp: improve ComputeServiceAttachment fidelity
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a vague memory that the project-id annotation has to use some specific variable value otherwise the postsubmit dynamic test will fail... 😞
Here it is k8s-config-connector/pkg/test/gcp/gcp.go Line 58 in abd5042
|
865b7a3
to
bcec9bd
Compare
bcec9bd
to
aeb7e1f
Compare
Looks like we can just create this project, rather than using TEST_DEPENDENDENT_ORG_PROJECT_ID
aeb7e1f
to
4c4aa81
Compare
Well let's try it and fix that if need be :-) |
A few tweaks that get the ComputeServiceAttachment test lining up (even if the results aren't exact yet).
4c4aa81
to
3423fe9
Compare