Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pass in just enough args to ResolveProject #3233

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

yuwenma
Copy link
Collaborator

@yuwenma yuwenma commented Nov 21, 2024

Change description

Fixes #

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@justinsb
Copy link
Collaborator

justinsb commented Nov 21, 2024

I think we do this after #3234?

@yuwenma yuwenma force-pushed the project-minor branch 4 times, most recently from 41bc550 to 18a044c Compare November 22, 2024 16:25
@yuwenma
Copy link
Collaborator Author

yuwenma commented Nov 22, 2024

I think we do this after #3234?

I make this PR to be able to merge separately from #3234. Its self is to improve the project function usage.

@google-oss-prow google-oss-prow bot added the lgtm label Dec 3, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 333efdd into GoogleCloudPlatform:master Dec 3, 2024
18 checks passed
@yuwenma yuwenma added this to the 1.126 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants