Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Avoid here links #3195

Merged
merged 13 commits into from
Nov 20, 2024
Merged

[CHORE] Avoid here links #3195

merged 13 commits into from
Nov 20, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 19, 2024

Change description

Replace (click) here links with accessibility friendly links

For more information, see:

(?i)(?:>|\[)(?:(?:click |)here|(?:read |)more)(?:</|\]\()

split per #3062 (comment)

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

jsoref added 13 commits November 19, 2024 09:30
@jsoref
Unindent code block
086e953 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Avoid here links: contributing to projects
e870375 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Avoid here links: details about the Absent behavior
40625a1 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Avoid here links: generated
8b8d481 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Avoid here links: how app engine requests are routed
da8641b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Avoid here links: instructions
4f529eb 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Avoid here links: list of available properties
a97b607 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Avoid here links: list of the available pre-defined roles
22b0f58 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Avoid here links: register the controller
d36198c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Avoid here links: resource reference guidelines
376420c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Avoid here links: sample guidelines
324ecb5 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Avoid here links: supported formats
a12d60d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Avoid here links: understanding roles
8957bbe 
Signed-off-by: Josh Soref <[email protected]>
yuwenma
yuwenma reviewed Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 20, 2024
@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 031b773 into GoogleCloudPlatform:master Nov 20, 2024
3 checks passed
@yuwenma yuwenma mentioned this pull request Nov 20, 2024
Open
14 tasks
@jsoref jsoref deleted the avoid-here-links branch November 20, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenma yuwenma yuwenma left review comments

Assignees

@yuwenma yuwenma

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoref @yuwenma