Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update release notes 1.125 #3115

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

gemmahou
Copy link
Collaborator

@gemmahou gemmahou commented Nov 6, 2024

Change description

Fixes #

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.


* `ComputeFirewallPolicyRule`

* You can use the alpha.cnrm.cloud.google.com/reconciler: direct annotation on ComputeFirewallPolicyRule resource to opt-in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: code quote alpha.cnrm.cloud.google.com/reconciler: direct

@yuwenma
Copy link
Collaborator

yuwenma commented Nov 11, 2024

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 11, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b39c172 into GoogleCloudPlatform:master Nov 11, 2024
3 checks passed
@gemmahou gemmahou deleted the release125 branch November 11, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants