Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: roundtrip for DataformRepository #2678

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Conversation

acpana
Copy link
Collaborator

@acpana acpana commented Sep 11, 2024

Adds a fuzz roundtrip for DataformRepository.

Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acpana acpana changed the title tests: roundtrip tests: roundtrip for DataformRepository Sep 12, 2024
@acpana
Copy link
Collaborator Author

acpana commented Sep 12, 2024

I was going to add that as part of #2685 -- I noticed we don't run the fuzzing in the presubmit CI. 🤔 I can also add it here and keep the other PR focused on the CI job.

Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
@yuwenma
Copy link
Collaborator

yuwenma commented Sep 14, 2024

/lgtm
/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9b44b34 into master Sep 14, 2024
16 checks passed
@yuwenma yuwenma added this to the 1.123 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants