Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add direct reconciler for FirestoreDatabase" #2671

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

jasonvigil
Copy link
Collaborator

Reverts #2642

Merge conflict with #2633

@jasonvigil jasonvigil requested a review from yuwenma September 10, 2024 21:27
@yuwenma
Copy link
Collaborator

yuwenma commented Sep 10, 2024

/lgtm
/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonvigil jasonvigil merged commit b7089ad into master Sep 10, 2024
16 of 18 checks passed
@jasonvigil jasonvigil deleted the revert-2642-firestore branch September 10, 2024 21:42
@yuwenma yuwenma added this to the 1.123 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants