Add test case for SQLInstance location preference #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold need to rebase and re-run compare-mock after #2653 merges |
jasonvigil
force-pushed
the
sqlinstance-locationpreference
branch
from
e8594ae to
3e3b84b
Compare
Update locationPreference mapping code to improve readability, make similar to generated mapping code. Also, update ipConfiguration export code (this was missed before).
jasonvigil
force-pushed
the
sqlinstance-locationpreference
branch
from
3e3b84b to
f9aa2b1
Compare
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 82b7341
into
GoogleCloudPlatform:master
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update locationPreference mapping code to improve readability, make similar to generated mapping code.
Also, update ipConfiguration export code (this was missed before).