chore: improve fidelity of MockKMS #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwenma
commented
Sep 6, 2024
| @@ -123,17 +123,11 @@ func (r *kmsServer) CreateCryptoKeyVersion(ctx context.Context, req *pb.CreateCr | |||
| now := time.Now() | |||
|
|
|||
| var obj *pb.CryptoKeyVersion | |||
| if req.GetCryptoKeyVersion() == nil { | |||
There was a problem hiding this comment.
CryptoKeyVersion is required in the CreateKeyVersion request. The code should not hit this line.
There was a problem hiding this comment.
I think about whether we will panic if it isn't provided and whether that's harder to diagnose. That said, it's a mock, so ... not a big deal.
justinsb
approved these changes
Sep 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 1a6cc70
into
GoogleCloudPlatform:master
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Fixes #
Tests you have done
make ready-prto ensure this PR is ready for review.