Add support for deleting resources in reverse order by stage. #2582
Conversation
|
/assign @barney-s |
hankfreund
force-pushed
the
delete_annotations
branch
from
643d39a to
2f0dbd1
Compare
experiments/compositions/composition/internal/controller/expander_reconciler.go
Outdated
Show resolved
Hide resolved
experiments/compositions/composition/internal/controller/expander_reconciler.go
Outdated
Show resolved
Hide resolved
experiments/compositions/composition/internal/controller/expander_reconciler.go
Show resolved
Hide resolved
experiments/compositions/composition/internal/controller/expander_reconciler.go
Show resolved
Hide resolved
This solution makes use of the ApplySet annotations for GroupKinds and Namespaces. When a facade deletion request is received, the ApplySet data is read from the Plan to know what GKs to find and delete, and which namespaces to search. The resources are further filtered by the ApplySet ID they are automatically labeled with. Stage order information is added to the Plan so the deletion processing can iterate over them in reverse.
hankfreund
force-pushed
the
delete_annotations
branch
from
2f0dbd1 to
96ea0c1
Compare
| } | ||
| numFound += n | ||
| } | ||
| if numFound > 0 { |
There was a problem hiding this comment.
Logic here implies if a resource in a particular stage is not deleted (for whatever reason), the deletion of rest of the resources are blocked (fits the mental model). This is great if the delete pending resource eventually is removed (O(mins)). Iam thinking if we need to add a timeout (by looking at delete timestamp of the resource) to make progress if a resource is stuck in deletion. We can proceed to delete other resources after a timeout. We dont have to delete the plan/inputcr.
There was a problem hiding this comment.
we can do it in another PR ?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barney-s The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 0784071
into
GoogleCloudPlatform:master
Change description
This solution makes use of the ApplySet annotations for GroupKinds and Namespaces. When a facade deletion request is received, the ApplySet data is read from the Plan to know what GKs to find and delete, and which namespaces to search. The resources are further filtered by the ApplySet ID they are automatically labeled with.
Stage order information is added to the Plan so the deletion processing can iterate over them in reverse, and as a label on each expanded resource.