-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add FirestoreDatabase direct controller #2579
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @jasonvigil, are you seeing similar issues when generating the types as mentioned in #2573 (comment)? |
I think so. There are quite a few extra resources (besides |
81de453
to
2ed542b
Compare
2ed542b
to
60e89c4
Compare
I updated the implementation of type generator in #2573. Would like to see if that works better for your resource. |
60e89c4
to
5c8ec76
Compare
Thank you @jingyih! Pulled in your changes. It no longer generates extra resources. |
Stopping using different parent message when generating goType name as a field vs. as a struct.
5c8ec76
to
936089a
Compare
Based on example in #2573