Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add FirestoreDatabase direct controller #2579

Closed

Conversation

jasonvigil
Copy link
Collaborator

Based on example in #2573

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jasonvigil. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonvigil jasonvigil marked this pull request as draft August 28, 2024 16:30
@jingyih
Copy link
Collaborator

jingyih commented Aug 28, 2024

Hi @jasonvigil, are you seeing similar issues when generating the types as mentioned in #2573 (comment)?

@jasonvigil
Copy link
Collaborator Author

@jingyih

Hi @jasonvigil, are you seeing similar issues when generating the types as mentioned in #2573 (comment)?

I think so. There are quite a few extra resources (besides Database) generated in types.generated.go. Though I am not sure if that is intentional (?)

@jingyih
Copy link
Collaborator

jingyih commented Aug 29, 2024

I updated the implementation of type generator in #2573. Would like to see if that works better for your resource.

@jasonvigil
Copy link
Collaborator Author

Thank you @jingyih! Pulled in your changes. It no longer generates extra resources.

@jasonvigil jasonvigil changed the title WIP: Generate types for FirestoreDatabase WIP: Add FirestoreDatabase direct controller Aug 30, 2024
@jasonvigil jasonvigil closed this Sep 6, 2024
@jasonvigil jasonvigil deleted the firestore-types branch September 6, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants