Remove incorrect assertions for invalid expander tests #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two tests which verify controller behavior for compositions with invalid expanders have been asserting that the resultant Plan objects similarly show an error. This check is incorrect because a resource relying on an invalid Composition should never generate a Plan to begin with. An existing bug is creating Plans incorrectly and the test was mistakenly checking on those. Remove the check of the Plan and only verify the Composition status.
|
/assign @barney-s |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barney-s The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 0ceef9a
into
GoogleCloudPlatform:master
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
The two tests which verify controller behavior for compositions with invalid expanders have been asserting that the resultant Plan objects similarly show an error. This check is incorrect because a resource relying on an invalid Composition should never generate a Plan to begin with. An existing bug is creating Plans incorrectly and the test was mistakenly checking on those.
Remove the check of the Plan and only verify the Composition status.