Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring: add blankView #2192

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

justinsb
Copy link
Collaborator

@justinsb justinsb commented Jun 29, 2024

  • monitoring: add emptyView

Builds on #2191.

@justinsb justinsb force-pushed the blankview branch 2 times, most recently from f68b9bf to 2a5379c Compare June 29, 2024 15:07
@justinsb
Copy link
Collaborator Author

I think this is relatively minor, doesn't need to be in 1.120, but also low risk if we would like it in there.

@justinsb justinsb changed the title monitoring: add emptyView monitoring: add blankView Jun 29, 2024
@justinsb justinsb added this to the 1.120 milestone Jul 1, 2024
@yuwenma
Copy link
Collaborator

yuwenma commented Jul 1, 2024

/approve

Looks like you need to regenerate the deep copy file.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuwenma
Copy link
Collaborator

yuwenma commented Jul 2, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 2, 2024
@google-oss-prow google-oss-prow bot merged commit 520f8c3 into GoogleCloudPlatform:master Jul 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants