Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoringdashboard: add dashboardFilters #2189

Conversation

justinsb
Copy link
Collaborator

No description provided.

@justinsb justinsb added this to the 1.120 milestone Jun 28, 2024
@justinsb justinsb force-pushed the monitoringdashboard_dashboardfilters branch from b800718 to ba91ffa Compare June 28, 2024 18:17
Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Looks great!

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb justinsb force-pushed the monitoringdashboard_dashboardfilters branch from ba91ffa to 7f295d8 Compare June 28, 2024 21:54
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 28, 2024
@justinsb
Copy link
Collaborator Author

Rebased ... we should probably try to avoid lots of PRs on the same resource in future :-)

@yuwenma
Copy link
Collaborator

yuwenma commented Jun 28, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 28, 2024
@justinsb justinsb force-pushed the monitoringdashboard_dashboardfilters branch from 7f295d8 to 6914da3 Compare June 28, 2024 23:17
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 28, 2024
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot merged commit 14966c3 into GoogleCloudPlatform:master Jun 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants