vcr: Update output path #1564
Merged
vcr: Update output path #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
gemmahou
force-pushed
the
vcr-update-path
branch
from
d0455c4 to
2e0b112
Compare
justinsb
reviewed
Apr 16, 2024
|
One nit over using an env var to pass parameters (and a suggestion around function naming), but generally lgtm. I'm guessing this is going to need a rebase anyway, but we'll see what happens after #1552 merges... |
gemmahou
force-pushed
the
vcr-update-path
branch
2 times, most recently
from
4521c83 to
fef34cd
Compare
|
Thanks @gemmahou /approve |
gemmahou
force-pushed
the
vcr-update-path
branch
from
fef34cd to
cb1a608
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit f0d0678
into
GoogleCloudPlatform:master
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Fixes #1552 (comment)
Tests you have done
make ready-prto ensure this PR is ready for review.