Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mockgcp: support for LoggingLogBucket #1545

Merged

Conversation

justinsb
Copy link
Collaborator

  • tests: captured test output for projectlogbucket
  • mockgcp: add support for LoggingLogBucket
  • mockgcp: Allow services to rewrite errors for accurate golden testing

@justinsb
Copy link
Collaborator Author

/assign @acpana

(Also ... ask me for the backstory here!)

@acpana
Copy link
Collaborator

acpana commented Apr 16, 2024

This LGTM overall but I think the test harness is coming to our rescue! Digging into the logs I see that test failures for

* 1. TestAllInSeries/samples/organization-log-bucket
* 2. TestAllInSeries/samples/billing-account-log-bucke

may actually be genuine:

1.  Error 400: name \"organizations/123450001/locations/global/buckets/_Default\" is not valid"}
2. .. resource reference is missing required 'name' field"} ...

sample run: https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/8648481995/job/23786979096?pr=1545

@justinsb justinsb force-pushed the mockgcp_log_bucket branch from 37c85aa to b1ad86d Compare May 8, 2024 01:46
@justinsb
Copy link
Collaborator Author

justinsb commented May 8, 2024

Rebased and added more of the cases covered in our samples to mockgcp!

@justinsb justinsb force-pushed the mockgcp_log_bucket branch from b1ad86d to d2718e4 Compare May 8, 2024 02:39
@acpana
Copy link
Collaborator

acpana commented May 8, 2024

thanks for following up here 🥇 🙏🏼

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label May 8, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acpana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f44ca4e into GoogleCloudPlatform:master May 8, 2024
11 checks passed
@yuwenma yuwenma added this to the 1.117 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants