WIP: genapi support for TagsTagKey #1477
Conversation
justinsb
commented
Apr 1, 2024
justinsb
commented
- mockgcp: Implement TagsTagValue
- tests: run deletion in order when we're doing golden testing
- chore: add scripts to help developing mockgcp
- tests: update golden output for tagkeyprojectbasic
- genapi: Add support for TagsTagKey
- chore: update http log
This does mean that we have to have the objects pre-ordered correctly, but it means that (deletion) requests will be made in a consistent order.
* hack/record-gcp will record the golden http output * hack/compare-mock will update with the http output from mockgcp; expected to be the same.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @anhdle-sso and @acpana This builds on #1434, adding the genapi logic. WIP because we should do #1434 first, and there are still some obvious issues here, and we probably want to get the tests with the KRM status first, but ... we can work on these things together! |
|
It looks like we cherry-picked everything out of here, so this is all merged now! /close |
|
@justinsb: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
