Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vendor in deps #1440

Closed
wants to merge 1 commit into from
Closed

chore: vendor in deps #1440

wants to merge 1 commit into from

Conversation

acpana
Copy link
Collaborator

@acpana acpana commented Mar 26, 2024

reviewer notes: I'll use this WIP PR as a tracking ticket

  • this is mostly a go mod tidy && go mod vendor
  • also don't gitignore the vendor directory

TODO:

  • solve any issues

don't gitignore them

Signed-off-by: Alex Pana <[email protected]>
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from acpana. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Collaborator

I for one was not sad to see vendor gone :-)

@justinsb justinsb added this to the Future milestone Mar 26, 2024
@acpana
Copy link
Collaborator Author

acpana commented Apr 4, 2024

I think we are going to punt/ wait on this to see if we actually need to vendor our deps back in.

The good news is that it seems this is not too bad.

@acpana acpana closed this Apr 4, 2024
@acpana acpana deleted the acpana/vendor branch May 20, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants