chore: fix mispelling #1396
Merged
chore: fix mispelling #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acpana
reviewed
Mar 19, 2024
pkg/krmtotf/tftokrm.go
Outdated
| @@ -435,7 +435,7 @@ func getValueFromState(state map[string]interface{}, key string) (string, bool) | |||
| // | |||
| // prevSpec is used for multiple purposes: | |||
| // - ensures the returned result has a similar order for objects in lists, reducing | |||
| // the percieved diff when applied. | |||
| // the `perceived diff when applied. | |||
There was a problem hiding this comment.
Suggested change
| // the `perceived diff when applied. | |
| // the perceived diff when applied. |
|
/hold for author to merge/ follow up on nit |
|
/lgtm thanks for doing this 🥇 glad it wasn't too bad hehe |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acpana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/unhold |
google-oss-prow
bot
merged commit be5a924
into
GoogleCloudPlatform:master
8 checks passed
199201shubhamsahu
pushed a commit
to 199201shubhamsahu/k8s-config-connector
that referenced
this pull request
Mar 26, 2024
* chore: fix mispelling * Update tftokrm.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Fixes #1286
Tests you have done
make ready-prto ensure this PR is ready for review.