vcr: Apply custom matcher #1372
Conversation
gemmahou
force-pushed
the
vcr-matcher
branch
2 times, most recently
from
3872857 to
114fc17
Compare
tests/e2e/unified_test.go
Outdated
| // Use both indexes to get the string contains the message we need to remove | ||
| temp := s[startIndex+len(keyword) : startIndex+len(keyword)+endIndex] | ||
| // Replace | ||
| s = strings.Replace(s, temp, "fake debug info", -1) |
There was a problem hiding this comment.
I think you can just remove it, IIUC it only shows up for (some) googlers / callers. So for outside contributors, it might just be confusing.
There was a problem hiding this comment.
I plan to remove this this whole code block in #1393.
To speed up the test, I'd like to remove unnecessary interactions from the yaml file. For example, remove failed HTTP logs with error codes 404/400/403 and repeated logs that come from the retry transport.
I left a TODO here stating that the code will be removed in an upcoming PR.
|
Some nits, but this PR looks to have addressed some of the things that confused me in the other (WIP) PR. So: I would hold this for you to sequence as you prefer, because I've lost track of the sequencing, but it needs a rebase anyway. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Code review comments have been addressed. |
google-oss-prow
bot
merged commit 523d79a
into
GoogleCloudPlatform:master
Change description
Add custom matcher to match incoming request against saved request
Tests you have done
make ready-prto ensure this PR is ready for review.