Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcr: use go-vcr package to setup vcr recorder #1346

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

gemmahou
Copy link
Collaborator

@gemmahou gemmahou commented Mar 11, 2024

Change description

In this PR, I implemented the same thing as in #1345, with a different approach. I incorporated go-vcr package and used its recorder.

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@gemmahou gemmahou force-pushed the vcr-wip branch 2 times, most recently from b1bf46f to e69df2b Compare March 12, 2024 00:23
@gemmahou gemmahou changed the title WIP: use go-vcr package for vcr testing use go-vcr package to setup vcr recorder Mar 12, 2024
config/tests/samples/create/harness.go Outdated Show resolved Hide resolved
config/tests/samples/create/harness.go Outdated Show resolved Hide resolved
config/tests/samples/create/harness.go Outdated Show resolved Hide resolved
config/tests/samples/create/harness.go Outdated Show resolved Hide resolved
tests/e2e/unified_test.go Outdated Show resolved Hide resolved
@justinsb
Copy link
Collaborator

A few nit but LGTM... can we add a VCR test as a GitHub actions presubmit (maybe just running one subtest to start with?)

@gemmahou gemmahou changed the title use go-vcr package to setup vcr recorder vcr: use go-vcr package to setup vcr recorder Mar 13, 2024
@justinsb justinsb added this to the Future milestone Mar 14, 2024
@gemmahou
Copy link
Collaborator Author

A few nit but LGTM... can we add a VCR test as a GitHub actions presubmit (maybe just running one subtest to start with?)

I'm thinking about that too, I'll have that setup in a future PR and see how it works. I'm also thinking about if we can migrate VCR test into our prow job so that we can save cassette files in GCS private storage, similar to artifacts http logs.

@gemmahou gemmahou force-pushed the vcr-wip branch 2 times, most recently from 0bd8e26 to fbb39fb Compare March 15, 2024 02:55
@gemmahou gemmahou modified the milestones: Future, 1.115 Mar 19, 2024
@maqiuyujoyce
Copy link
Collaborator

Looks like it's the diff base for #1349 though I've already left some non-blocking comments there. /lgtm

@maqiuyujoyce
Copy link
Collaborator

/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maqiuyujoyce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemmahou gemmahou added the lgtm label Mar 21, 2024
@google-oss-prow google-oss-prow bot merged commit 298e6cc into GoogleCloudPlatform:master Mar 21, 2024
9 checks passed
@gemmahou gemmahou deleted the vcr-wip branch March 21, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants