-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcr: use go-vcr package to setup vcr recorder #1346
Conversation
b1bf46f
to
e69df2b
Compare
vcr/fixtures/cassette/TestAllInSeries_fixtures_computenodetemplate.yaml
Outdated
Show resolved
Hide resolved
vcr/fixtures/cassette/TestAllInSeries_fixtures_computenodetemplate.yaml
Outdated
Show resolved
Hide resolved
vcr/fixtures/cassette/TestAllInSeries_fixtures_computenodetemplate.yaml
Outdated
Show resolved
Hide resolved
vcr/fixtures/cassette/TestAllInSeries_fixtures_computenodetemplate.yaml
Outdated
Show resolved
Hide resolved
vcr/fixtures/cassette/TestAllInSeries_fixtures_computenodetemplate.yaml
Outdated
Show resolved
Hide resolved
A few nit but LGTM... can we add a VCR test as a GitHub actions presubmit (maybe just running one subtest to start with?) |
I'm thinking about that too, I'll have that setup in a future PR and see how it works. I'm also thinking about if we can migrate VCR test into our prow job so that we can save cassette files in GCS private storage, similar to artifacts http logs. |
0bd8e26
to
fbb39fb
Compare
Looks like it's the diff base for #1349 though I've already left some non-blocking comments there. /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maqiuyujoyce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
298e6cc
into
GoogleCloudPlatform:master
Change description
In this PR, I implemented the same thing as in #1345, with a different approach. I incorporated go-vcr package and used its recorder.
Tests you have done
make ready-pr
to ensure this PR is ready for review.