Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Handcode MonitoringDashboard #1234

Conversation

justinsb
Copy link
Collaborator

  • mockgcp: Support for MonitoringDashboard
  • mockgcp: Add generated monitoring code
  • tests: fix typo in monitoringdashboard test
  • APIKeysKey: Create direct controller
  • WIP: more mappings including enums
  • WIP: Monitoring controller
  • tests: only skip 404 on operation gets
  • Remove special cases
  • tests: use more intuitive values in monitoringdashboard fixture
  • WIP: http output
  • go.mod / go.sum updates

@justinsb justinsb changed the title handcode monitoringdashboard WIP: Handcode MonitoringDashboard Feb 13, 2024
@justinsb justinsb force-pushed the handcode_monitoringdashboard branch from 137cede to 2e1023a Compare February 14, 2024 13:31
@justinsb justinsb force-pushed the handcode_monitoringdashboard branch from 2e1023a to 079507a Compare March 16, 2024 10:23
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Collaborator Author

We've now done this using our direct approach

/close

@google-oss-prow google-oss-prow bot closed this Aug 12, 2024
Copy link
Contributor

@justinsb: Closed this PR.

In response to this:

We've now done this using our direct approach

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant