Skip to content

Commit

Permalink
Merge pull request #3205 from jsoref/spelling-2
Browse files Browse the repository at this point in the history
[CHORE] Spelling 2/n
  • Loading branch information
google-oss-prow[bot] authored Nov 20, 2024
2 parents 8de3627 + cf616e7 commit bd9c504
Show file tree
Hide file tree
Showing 63 changed files with 78 additions and 78 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

We'd love to accept your patches and contributions to this project. We use this
GitHub project as our primary source of truth and the main development
repository for Config Connetor. The source code in this project is also
repository for Config Connector. The source code in this project is also
mirrored to internal Google repository for the purposes of releases.

## Contributor License Agreement
Expand Down
2 changes: 1 addition & 1 deletion apis/bigquery/v1beta1/dataset_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type BigQueryDatasetSpec struct {
// afterwards, and does not alter the existing tables.
// The following values are supported:
//
// * 'und:ci': undetermined locale, case insensitive.
// * 'und:ci': undetermined locale, case-insensitive.
// * '': empty string. Default to case-sensitive behavior.
DefaultCollation *string `json:"defaultCollation,omitempty"`

Expand Down
2 changes: 1 addition & 1 deletion apis/networkconnectivity/v1alpha1/types.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ spec:
afterwards, and does not alter the existing tables.
The following values are supported:
* 'und:ci': undetermined locale, case insensitive.
* 'und:ci': undetermined locale, case-insensitive.
* '': empty string. Default to case-sensitive behavior.
type: string
defaultEncryptionConfiguration:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ spec:
description: |-
URLs to certificate manager certificate resources that are used to authenticate connections between users and the load balancer.
Currently, you may specify up to 15 certificates. Certificate manager certificates do not apply when the load balancing scheme is set to INTERNAL_SELF_MANAGED.
sslCertificates and certificateManagerCertificates fields can not be defined together.
sslCertificates and certificateManagerCertificates fields cannot be defined together.
oneOf:
- not:
required:
Expand Down Expand Up @@ -99,7 +99,7 @@ spec:
can only be set for global target proxies. This field is only supported
for EXTERNAL and EXTERNAL_MANAGED load balancing schemes.
For INTERNAL_MANAGED, use certificateManagerCertificates instead.
sslCertificates and certificateMap fields can not be defined together.
sslCertificates and certificateMap fields cannot be defined together.
oneOf:
- not:
required:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ spec:
type: string
defaultSchemaID:
description: Output only. The id of the default [Schema][google.cloud.discoveryengine.v1.Schema]
asscociated to this data store.
associated to this data store.
type: string
type: object
type: object
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ spec:
''allServices'' and a specific service, then the union of the two
audit configs is used for that service: the ''logTypes'' specified
in each ''auditLogConfig'' are enabled, and the ''exemptedMembers''
in each ''auditLogConfg'' are exempted.'
in each ''auditLogConfig'' are exempted.'
type: string
required:
- auditLogConfigs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ spec:
both ''allServices'' and a specific service, then the union
of the two audit configs is used for that service: the ''logTypes''
specified in each ''auditLogConfig'' are enabled, and the
''exemptedMembers'' in each ''auditLogConfg'' are exempted.'
''exemptedMembers'' in each ''auditLogConfig'' are exempted.'
type: string
required:
- auditLogConfigs
Expand Down
6 changes: 3 additions & 3 deletions config/servicemappings/compute.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1637,7 +1637,7 @@ spec:
targetField: name
idTemplate: "projects/{{project}}/regions/{{region}}/networkEndpointGroups/{{name}}"
idTemplateCanBeUsedToMatchResourceName: false
# TODO: (b/233123518) Config Connector CLI can not currently support ComputeRegionNetworkEndpointGroup.
# TODO: (b/233123518) Config Connector CLI cannot currently support ComputeRegionNetworkEndpointGroup.
resourceAvailableInAssetInventory: false
resourceReferences:
- key: serviceRef
Expand Down Expand Up @@ -2472,7 +2472,7 @@ spec:
description: |-
URLs to certificate manager certificate resources that are used to authenticate connections between users and the load balancer.
Currently, you may specify up to 15 certificates. Certificate manager certificates do not apply when the load balancing scheme is set to INTERNAL_SELF_MANAGED.
sslCertificates and certificateManagerCertificates fields can not be defined together.
sslCertificates and certificateManagerCertificates fields cannot be defined together.
gvk:
kind: CertificateManagerCertificate
version: v1beta1
Expand Down Expand Up @@ -2508,7 +2508,7 @@ spec:
can only be set for global target proxies. This field is only supported
for EXTERNAL and EXTERNAL_MANAGED load balancing schemes.
For INTERNAL_MANAGED, use certificateManagerCertificates instead.
sslCertificates and certificateMap fields can not be defined together.
sslCertificates and certificateMap fields cannot be defined together.
gvk:
kind: CertificateManagerCertificateMap
version: v1beta1
Expand Down
2 changes: 1 addition & 1 deletion crds/bigquery_v1beta1_bigquerydataset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ spec:
afterwards, and does not alter the existing tables.
The following values are supported:
* 'und:ci': undetermined locale, case insensitive.
* 'und:ci': undetermined locale, case-insensitive.
* '': empty string. Default to case-sensitive behavior.
type: string
defaultEncryptionConfiguration:
Expand Down
2 changes: 1 addition & 1 deletion crds/bigquery_v1beta1_bigqueryjob.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ spec:
projectionFields:
description: |-
Immutable. If sourceFormat is set to "DATASTORE_BACKUP", indicates which entity properties to load into BigQuery from a Cloud Datastore backup.
Property names are case sensitive and must be top-level properties. If no properties are specified, BigQuery loads all properties.
Property names are case-sensitive and must be top-level properties. If no properties are specified, BigQuery loads all properties.
If any named property isn't found in the Cloud Datastore backup, an invalid error is returned in the job result.
items:
type: string
Expand Down
2 changes: 1 addition & 1 deletion crds/compute_v1beta1_computefirewallpolicy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ spec:
type: integer
ruleTupleCount:
description: Total count of all firewall policy rule tuples. A firewall
policy can not exceed a set number of tuples.
policy cannot exceed a set number of tuples.
format: int64
type: integer
selfLink:
Expand Down
2 changes: 1 addition & 1 deletion crds/compute_v1beta1_computenetworkfirewallpolicy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ spec:
type: integer
ruleTupleCount:
description: Total count of all firewall policy rule tuples. A firewall
policy can not exceed a set number of tuples.
policy cannot exceed a set number of tuples.
type: integer
selfLink:
description: Server-defined URL for the resource.
Expand Down
4 changes: 2 additions & 2 deletions crds/compute_v1beta1_computetargethttpsproxy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ spec:
description: |-
URLs to certificate manager certificate resources that are used to authenticate connections between users and the load balancer.
Currently, you may specify up to 15 certificates. Certificate manager certificates do not apply when the load balancing scheme is set to INTERNAL_SELF_MANAGED.
sslCertificates and certificateManagerCertificates fields can not be defined together.
sslCertificates and certificateManagerCertificates fields cannot be defined together.
oneOf:
- not:
required:
Expand Down Expand Up @@ -112,7 +112,7 @@ spec:
can only be set for global target proxies. This field is only supported
for EXTERNAL and EXTERNAL_MANAGED load balancing schemes.
For INTERNAL_MANAGED, use certificateManagerCertificates instead.
sslCertificates and certificateMap fields can not be defined together.
sslCertificates and certificateMap fields cannot be defined together.
oneOf:
- not:
required:
Expand Down
2 changes: 1 addition & 1 deletion crds/compute_v1beta1_computeurlmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1952,7 +1952,7 @@ spec:
type: array
ignoreCase:
description: |-
Specifies that prefixMatch and fullPathMatch matches are case sensitive.
Specifies that prefixMatch and fullPathMatch matches are case-sensitive.
Defaults to false.
type: boolean
metadataFilters:
Expand Down
4 changes: 2 additions & 2 deletions crds/datacatalog_v1alpha1_datacatalogentry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,15 @@ spec:
description: |-
This field indicates the entry's source system that Data Catalog does not integrate with.
userSpecifiedSystem strings must begin with a letter or underscore and can only contain letters, numbers,
and underscores; are case insensitive; must be at least 1 character and at most 64 characters long.
and underscores; are case-insensitive; must be at least 1 character and at most 64 characters long.
type: string
userSpecifiedType:
description: |-
Entry type if it does not fit any of the input-allowed values listed in EntryType enum above.
When creating an entry, users should check the enum values first, if nothing matches the entry
to be created, then provide a custom value, for example "my_special_type".
userSpecifiedType strings must begin with a letter or underscore and can only contain letters,
numbers, and underscores; are case insensitive; must be at least 1 character and at most 64 characters long.
numbers, and underscores; are case-insensitive; must be at least 1 character and at most 64 characters long.
type: string
required:
- entryGroup
Expand Down
2 changes: 1 addition & 1 deletion crds/healthcare_v1alpha1_healthcarefhirstore.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ spec:
type: boolean
disableResourceVersioning:
description: |-
Immutable. Whether to disable resource versioning for this FHIR store. This field can not be changed after the creation
Immutable. Whether to disable resource versioning for this FHIR store. This field cannot be changed after the creation
of FHIR store. If set to false, which is the default behavior, all write operations will cause historical
versions to be recorded automatically. The historical versions can be fetched through the history APIs, but
cannot be updated. If set to true, no historical versions will be kept. The server will send back errors for
Expand Down
2 changes: 1 addition & 1 deletion crds/iam_v1beta1_iamauditconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ spec:
''allServices'' and a specific service, then the union of the two
audit configs is used for that service: the ''logTypes'' specified
in each ''auditLogConfig'' are enabled, and the ''exemptedMembers''
in each ''auditLogConfg'' are exempted.'
in each ''auditLogConfig'' are exempted.'
type: string
required:
- auditLogConfigs
Expand Down
2 changes: 1 addition & 1 deletion crds/iam_v1beta1_iampolicy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ spec:
both ''allServices'' and a specific service, then the union
of the two audit configs is used for that service: the ''logTypes''
specified in each ''auditLogConfig'' are enabled, and the
''exemptedMembers'' in each ''auditLogConfg'' are exempted.'
''exemptedMembers'' in each ''auditLogConfig'' are exempted.'
type: string
required:
- auditLogConfigs
Expand Down
2 changes: 1 addition & 1 deletion crds/memcache_v1beta1_memcacheinstance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ spec:
scheduleDeadlineTime:
description: |-
Output only. The deadline that the maintenance schedule start time
can not go beyond, including reschedule.
cannot go beyond, including reschedule.
A timestamp in RFC3339 UTC "Zulu" format, with nanosecond
resolution and up to nine fractional digits.
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ spec:
type: array
ignoreCase:
description: Specifies that prefixMatch and
fullPathMatch matches are case sensitive.
fullPathMatch matches are case-sensitive.
type: boolean
pathTemplateMatch:
description: |-
Expand Down Expand Up @@ -537,8 +537,8 @@ spec:
Cookie names:
- must be valid RFC 6265 "cookie-name" tokens
- are case sensitive
- cannot start with "Edge-Cache-" (case insensitive)
- are case-sensitive
- cannot start with "Edge-Cache-" (case-insensitive)
Note that specifying several cookies, and/or cookies that have a large range of values (e.g., per-user) will dramatically impact the cache hit rate, and may result in a higher eviction rate and reduced performance.
Expand All @@ -551,7 +551,7 @@ spec:
Names of HTTP request headers to include in cache keys. The value of the header field will be used as part of the cache key.
- Header names must be valid HTTP RFC 7230 header field values.
- Header field names are case insensitive
- Header field names are case-insensitive
- To include the HTTP method, use ":method"
Note that specifying several headers, and/or headers that have a large range of values (e.g. per-user) will dramatically impact the cache hit rate, and may result in a higher eviction rate and reduced performance.
Expand Down
2 changes: 1 addition & 1 deletion crds/networkservices_v1beta1_networkservicesgateway.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ spec:
description: Immutable. Required. Immutable. Scope determines how
configuration across multiple Gateway instances are merged. The
configuration for multiple Gateway instances with the same scope
will be merged as presented as a single coniguration to the proxy/load
will be merged as presented as a single configuration to the proxy/load
balancer. Max length 64 characters. Scope should start with a letter
and can only have letters, numbers, hyphens.
type: string
Expand Down
2 changes: 1 addition & 1 deletion crds/networkservices_v1beta1_networkservicesgrpcroute.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ spec:
properties:
caseSensitive:
description: Optional. Specifies that matches are
case sensitive. The default value is true. case_sensitive
case-sensitive. The default value is true. case_sensitive
must not be used with a type of REGULAR_EXPRESSION.
type: boolean
grpcMethod:
Expand Down
4 changes: 2 additions & 2 deletions crds/networkservices_v1beta1_networkserviceshttproute.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ spec:
pathRedirect:
description: The path that will be used in the redirect
response instead of the one that was supplied in the
request. path_redirect can not be supplied together
request. path_redirect cannot be supplied together
with prefix_redirect. Supply one alone or neither.
If neither is supplied, the path of the original request
will be used for the redirect.
Expand Down Expand Up @@ -626,7 +626,7 @@ spec:
type: array
ignoreCase:
description: Specifies if prefix_match and full_path_match
matches are case sensitive. The default value is false.
matches are case-sensitive. The default value is false.
type: boolean
prefixMatch:
description: The HTTP request path value must begin with
Expand Down
4 changes: 2 additions & 2 deletions crds/redis_v1beta1_redisinstance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ spec:
scheduleDeadlineTime:
description: |-
Output only. The deadline that the maintenance schedule start time
can not go beyond, including reschedule.
cannot go beyond, including reschedule.
A timestamp in RFC3339 UTC "Zulu" format, with nanosecond
resolution and up to nine fractional digits.
type: string
Expand Down Expand Up @@ -433,7 +433,7 @@ spec:
scheduleDeadlineTime:
description: |-
Output only. The deadline that the maintenance schedule start time
can not go beyond, including reschedule.
cannot go beyond, including reschedule.
A timestamp in RFC3339 UTC "Zulu" format, with nanosecond
resolution and up to nine fractional digits.
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ The `status.externalRef` shall use the [cloud asset inventory](https://cloud.go

* If user specifies the service-generated ID in the `spec.resourceID` field, the Direct reconciler will acquire the resource if the `status.externalRef` is not assigned.

### Backward compatibiltiy for TF/DCL based reconcilers
### Backward compatibility for TF/DCL based reconcilers

The existing TF-based and DCL-based reconciliation treats the `spec.resourceID` as the single Source of Truth to identify a GCP resource. It writes back the `spec.resourceID` after reconciliation. Here are [the known problems](https://github.com/GoogleCloudPlatform/k8s-config-connector/issues/2765). Config Connector will keep the bahavior of these resources, until they are migrated to the Direct reconciler.

Expand Down
Loading

0 comments on commit bd9c504

Please sign in to comment.