Skip to content

Commit

Permalink
Add presubmits for compositions.
Browse files Browse the repository at this point in the history
- Add github action targetting experiments/**
- Add tests for jinja expander
- fix test data in compositions to trigger tests
  • Loading branch information
barney-s committed May 15, 2024
1 parent da7ef39 commit 7066404
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 2 deletions.
38 changes: 38 additions & 0 deletions .github/workflows/presubmit-compositions.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# Copyright 2023 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

name: presubmit-compositions

on:
pull_request:
types: [opened, synchronize, reopened]
paths:
- "experiments/**"
push:
branches: ["master"]
paths:
- "experiments/**"
jobs:
expander-jinja2:
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
- name: "verify expander-jinja2 in a kind cluster"
run: |
cd experiments/compositions/composition
make unit-test-expander-jinja2
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
cancel-in-progress: true
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ spec:
name: common
template: |
apiVersion: v1
kind: MonfigCap ## should fail
kind: ConfigMap
metadata:
name: common-config
namespace: {{ pconfigs.metadata.namespace }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ spec:
name: common
template: |
apiVersion: v1
kind: MonfigCap ## should fail
kind: ConfigMap
metadata:
name: common-config
namespace: {{ pconfigs.metadata.namespace }}
Expand Down

0 comments on commit 7066404

Please sign in to comment.