Skip to content

Commit

Permalink
direct controller for ComputeForwardingRule
Browse files Browse the repository at this point in the history
  • Loading branch information
gemmahou committed Aug 22, 2024
1 parent e41e189 commit 6c82d9c
Show file tree
Hide file tree
Showing 10 changed files with 713 additions and 191 deletions.
2 changes: 1 addition & 1 deletion hack/compare-mock
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ E2E_GCP_TARGET=mock \
GOLDEN_REQUEST_CHECKS=1 \
GOLDEN_OBJECT_CHECKS=1 \
WRITE_GOLDEN_OUTPUT=1 \
KCC_USE_DIRECT_RECONCILERS="SQLInstance" \
KCC_USE_DIRECT_RECONCILERS="SQLInstance,ComputeForwardingRule" \
RUN_E2E=1 \
go test ./tests/e2e -timeout 3600s -v -run $RUN_TESTS
101 changes: 101 additions & 0 deletions pkg/controller/direct/compute/client.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
// Copyright 2024 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package compute

import (
"context"
"fmt"
"net/http"

api "cloud.google.com/go/compute/apiv1"
"github.com/GoogleCloudPlatform/k8s-config-connector/pkg/config"
"google.golang.org/api/option"
)

type gcpClient struct {
config config.ControllerConfig
}

func newGCPClient(ctx context.Context, config *config.ControllerConfig) (*gcpClient, error) {
gcpClient := &gcpClient{
config: *config,
}
return gcpClient, nil
}

func (m *gcpClient) options() ([]option.ClientOption, error) {
var opts []option.ClientOption
if m.config.UserAgent != "" {
opts = append(opts, option.WithUserAgent(m.config.UserAgent))
}
if m.config.HTTPClient != nil {
// TODO: Set UserAgent in this scenario (error is: WithHTTPClient is incompatible with gRPC dial options)

httpClient := &http.Client{}
*httpClient = *m.config.HTTPClient
httpClient.Transport = &optionsRoundTripper{
config: m.config,
inner: m.config.HTTPClient.Transport,
}
opts = append(opts, option.WithHTTPClient(httpClient))
}
if m.config.UserProjectOverride && m.config.BillingProject != "" {
opts = append(opts, option.WithQuotaProject(m.config.BillingProject))
}

// TODO: support endpoints?
// if m.config.Endpoint != "" {
// opts = append(opts, option.WithEndpoint(m.config.Endpoint))
// }

return opts, nil
}

type optionsRoundTripper struct {
config config.ControllerConfig
inner http.RoundTripper
}

func (m *optionsRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
if m.config.UserAgent != "" {
req.Header.Set("User-Agent", m.config.UserAgent)
req.Header.Del("x-goog-request-params")
}
return m.inner.RoundTrip(req)
}

func (m *gcpClient) globalForwardingRuleClient(ctx context.Context) (*api.GlobalForwardingRulesClient, error) {
opts, err := m.options()
if err != nil {
return nil, err
}
client, err := api.NewGlobalForwardingRulesRESTClient(ctx, opts...)
if err != nil {
return nil, fmt.Errorf("building global ComputeForwardingRule client: %w", err)
}
return client, err
}

func (m *gcpClient) forwardingRuleClient(ctx context.Context) (*api.ForwardingRulesClient, error) {
opts, err := m.options()
if err != nil {
return nil, err
}
client, err := api.NewForwardingRulesRESTClient(ctx, opts...)
if err != nil {
return nil, fmt.Errorf("building ComputeForwardingRule client: %w", err)
}
return client, err
}
Loading

0 comments on commit 6c82d9c

Please sign in to comment.