Skip to content

Commit

Permalink
Merge pull request #3208 from jsoref/spelling-5
Browse files Browse the repository at this point in the history
[CHORE] Spelling 5/n
  • Loading branch information
google-oss-prow[bot] authored Nov 20, 2024
2 parents c1bdc7d + b9504f0 commit 1afa378
Show file tree
Hide file tree
Showing 41 changed files with 47 additions and 47 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ repo to quickly set up a local dev environment.
./docker-setup.sh
```

1. Exit your current session, then SSH back in to the VM. Then run the
1. Exit your current session, then SSH back into the VM. Then run the
following to ensure you have set up sudoless docker correctly:

```shell
Expand Down
8 changes: 4 additions & 4 deletions README.ConfigureResourceReferences.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Once it's determined, note down the field name and the referenced GCP resource n

Before you can identify what the resource is based on, you must convert
the Google Cloud resource name or Terraform type name into a
Config Connector kind name. Create a Github question in this repo for help
Config Connector kind name. Create a GitHub question in this repo for help
if you still can't find the Config Connector kind name after following these steps:

1. If you know the TF type name, you can do project-scoped search in your local
Expand All @@ -80,7 +80,7 @@ if you still can't find the Config Connector kind name after following these ste
[KCC reference doc](https://cloud.google.com/config-connector/docs/reference/overview).

1. If you can't find a KCC kind with the steps above, it's possible that the
referenced resource is not supported in KCC. Create a Github question in this repo
referenced resource is not supported in KCC. Create a GitHub question in this repo
to clarify. If you've determined that the KCC kind is not supported in
KCC, skip ahead to
[Configure reference resource in the service mappings](#configure-reference-in-the-service-mappings).
Expand Down Expand Up @@ -119,10 +119,10 @@ You can find a `Type` field for each argument, and two most common types are

1. If the field is not required, mark it as an ignored field following
[this example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/b746248cd5a9b30669380513de8fdc6b4c43018d/config/servicemappings/cloudbuild.yaml#L204).
1. If the field is required, create a Github question in this repo for
1. If the field is required, create a GitHub question in this repo for
further discussion.

1. If the field isn't a string or a list, create a Github question in this repo
1. If the field isn't a string or a list, create a GitHub question in this repo
for further discussion.

## Configure reference resource in the service mappings
Expand Down
2 changes: 1 addition & 1 deletion apis/dataflow/v1beta1/types.generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
2 changes: 1 addition & 1 deletion crds/container_v1beta1_containercluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1491,7 +1491,7 @@ spec:
properties:
eventType:
description: Can be used to filter what notifications
are sent. Valid values include include UPGRADE_AVAILABLE_EVENT,
are sent. Valid values include UPGRADE_AVAILABLE_EVENT,
UPGRADE_EVENT and SECURITY_BULLETIN_EVENT.
items:
type: string
Expand Down
2 changes: 1 addition & 1 deletion crds/dns_v1beta1_dnsrecordset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ spec:
type: string
routingPolicy:
description: The configuration for steering traffic based on query.
You can specify either Weighted Round Robin(WRR) type or Geolocation(GEO)
You can specify either Weighted Round Robin(WRR) type or Geolocation (GEO)
type.
properties:
enableGeoFencing:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ spec:
Defaults to 86400s (1 day).
Cache directives that attempt to set a max-age or s-maxage higher than this, or an Expires header more than maxTtl seconds in the future will be capped at the value of maxTTL, as if it were the value of an s-maxage Cache-Control directive.
Cache directives that attempt to set a max-age or s-maxage greater than this, or an Expires header more than maxTtl seconds in the future will be capped at the value of maxTTL, as if it were the value of an s-maxage Cache-Control directive.
- The TTL must be >= 0 and <= 31,536,000 seconds (1 year)
- Setting a TTL of "0" means "always revalidate"
Expand Down
2 changes: 1 addition & 1 deletion crds/osconfig_v1beta1_osconfigguestpolicy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
2 changes: 1 addition & 1 deletion crds/privateca_v1beta1_privatecacertificate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ spec:
type: object
type: object
subjectKeyId:
description: Provides a means of identifiying certificates that
description: Provides a means of identifying certificates that
contain a particular public key, per https://tools.ietf.org/html/rfc5280#section-4.2.1.2.
properties:
keyId:
Expand Down
2 changes: 1 addition & 1 deletion crds/privateca_v1beta1_privatecacertificateauthority.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ spec:
type: object
type: object
subjectKeyId:
description: Provides a means of identifiying certificates that
description: Provides a means of identifying certificates that
contain a particular public key, per https://tools.ietf.org/html/rfc5280#section-4.2.1.2.
properties:
keyId:
Expand Down
2 changes: 1 addition & 1 deletion crds/vertexai_v1alpha1_vertexaifeaturestoreentitytype.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ spec:
value:
description: Specify a threshold value that can trigger the
alert. For categorical feature, the distribution distance
is calculated by L-inifinity norm. Each feature must have
is calculated by L-infinity norm. Each feature must have
a non-zero threshold if they need to be monitored. Otherwise
no alert will be triggered for that feature. The default
value is 0.3.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ type generatedGoField struct {

type generatedGoStruct struct {
name string // fully qualified name of the proto message
content []byte // the content of the genearted Go struct
content []byte // the content of the generated Go struct
}

func NewTypeUpdater(opts *UpdateTypeOptions) *TypeUpdater {
Expand Down Expand Up @@ -238,7 +238,7 @@ func (u *TypeUpdater) generate() error {

for _, msg := range u.dependentMessages {
var buf bytes.Buffer
klog.Infof("genearte Go code for messge %s", msg.FullName())
klog.Infof("generate Go code for messge %s", msg.FullName())
codegen.WriteMessage(&buf, msg)
u.generatedGoStructs = append(u.generatedGoStructs,
generatedGoStruct{
Expand Down
4 changes: 2 additions & 2 deletions dev/tools/controllerbuilder/scaffold/apis.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func (a *APIScaffolder) AddGroupVersionFile() error {
Version: a.Version,
PackageProtoTag: a.PackageProtoTag,
}
return scaffoldGropuVersionFile(docFilePath, cArgs)
return scaffoldGroupVersionFile(docFilePath, cArgs)
}

func (a *APIScaffolder) DocFileNotExist() bool {
Expand Down Expand Up @@ -183,7 +183,7 @@ func scaffoldDocFile(path string, cArgs *apis.APIArgs) error {
return nil
}

func scaffoldGropuVersionFile(path string, cArgs *apis.APIArgs) error {
func scaffoldGroupVersionFile(path string, cArgs *apis.APIArgs) error {
tmpl, err := template.New("groupversioninfo.go").Parse(apis.GroupVersionInfoTemplate)
if err != nil {
return fmt.Errorf("parse groupversion_info.go template: %w", err)
Expand Down
2 changes: 1 addition & 1 deletion docs/releasenotes/release-1.119.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
## New Fields:

* `ComputeForwardingRule`
* Added the `spec.target.serviceAttachmentRef` field, allowing a `ComputeForwaringRule` to target a `ComputeServiceAttachment`.
* Added the `spec.target.serviceAttachmentRef` field, allowing a `ComputeForwardingRule` to target a `ComputeServiceAttachment`.

* `ContainerCluster`
* Added previous output-only spec fields to `status.observedState`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ controller-runtime's Manager interface provides no way to check if a controller
`type Manager interface {}` : https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/manager/manager.go#L55
`type Cluster interface {}` : https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/cluster/cluster.go#L40

We would need to build an intrerface on top of the manager that supports checking if a controller exists in a manager.
We would need to build an interface on top of the manager that supports checking if a controller exists in a manager.

## No support for stopping a controller

Expand Down
2 changes: 1 addition & 1 deletion experiments/compositions/Design Notes/Feedback.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ Validations for facade input fields at which level (crd, expander, gatekeeper)
Default values for facade input fields (crd, expander, gatekeeper)
Troubleshooting
- make it easy to detect who needs to act Platform admin or AppTeamOperator
- who breaks glass and what is allowed (can appteam mutate generataed resources ? )
- who breaks glass and what is allowed (can appteam mutate generated resources ? )
- who carries the pager (admin & appteam OR appteam OR admin)
2 changes: 1 addition & 1 deletion experiments/kubectl-plan/pkg/plan/planner.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func (r *Planner) BuildPlan(ctx context.Context, objects []*unstructured.Unstruc
resource, err := target.ResourceForGVK(ctx, gvk)
if err != nil {
// The Kind doesn't even exist; the object can't exist already
// TODO: We should invalide mappings above, in case our cache is out of date
// TODO: We should invalidate mappings above, in case our cache is out of date
action.Type = ActionTypeCreate
plan.Spec.Actions = append(plan.Spec.Actions, action)
continue
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109947,7 +109947,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109947,7 +109947,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109947,7 +109947,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
2 changes: 1 addition & 1 deletion install-bundles/install-bundle-gcp-identity/crds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109947,7 +109947,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
2 changes: 1 addition & 1 deletion install-bundles/install-bundle-namespaced/crds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109947,7 +109947,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
2 changes: 1 addition & 1 deletion install-bundles/install-bundle-workload-identity/crds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109947,7 +109947,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
2 changes: 1 addition & 1 deletion mockgcp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Broadly the steps are:

1. Add the proto to the Makefile and run `make gen-proto` (or just `make`).

All google services are located in [googleapis Github repo](https://github.com/googleapis/googleapis/tree/master/google),
All google services are located in [googleapis GitHub repo](https://github.com/googleapis/googleapis/tree/master/google),
refer to your resource's API documentation to identify the service name, for example [privateca](https://cloud.google.com/certificate-authority-service/docs/reference/rest#service:-privateca.googleapis.com).
Once you identify the service, find the proper path to the proto files, for example:
`cloud/security/privateca/v1/*.proto`. Then replace the prefix `googleapis/google/` to `./third_party/googleapis/mockgcp/`,
Expand Down
2 changes: 1 addition & 1 deletion mockgcp/mockgkehub/gkehubfeature.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func (s *GKEHubFeature) CreateFeature(ctx context.Context, req *pb.CreateFeature
acmSpec := spec.GetConfigmanagement()
if acmSpec != nil {
if acmSpec.GetConfigSync() == nil && acmSpec.GetHierarchyController() == nil && acmSpec.GetPolicyController() == nil {
return nil, fmt.Errorf("none of configsync or hierachycontroller or policycontroller is specified under configmanagement for memebership %s", id)
return nil, fmt.Errorf("none of configsync or hierarchycontroller or policycontroller is specified under configmanagement for memebership %s", id)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107727,7 +107727,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108099,7 +108099,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109947,7 +109947,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107727,7 +107727,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108099,7 +108099,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109947,7 +109947,7 @@ spec:
type: string
type: object
id:
description: Required. Id of the artifact, which the installation
description: Required. ID of the artifact, which the installation
and update steps of this recipe can reference. Artifacts
in a recipe cannot have the same id.
type: string
Expand Down
2 changes: 1 addition & 1 deletion pkg/cli/outputsink/sink_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func TestDirectorySink(t *testing.T) {
testCases := []struct {
name string
sinkConstructor func(*schema.Provider, string) outputsink.OutputSink
// the file that will be read, with results passed in to the sink for testing
// the file that will be read, with results passed into the sink for testing
testCaseFile string
// the yaml file to use to pull unstructured schemas
unstructuredFile string
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 1afa378

Please sign in to comment.