feat: add managedinstancegroups

[charlie-haley]

This PR adds support for MIGs as well as updating some dependencies

[google-oss-prow]

Hi @charlie-haley. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[charlie-haley]

/assign @rramkumar1

[bowei]

/assign

[bowei]

reviewing -- generally change looks ok

[charlie-haley]

I just pushed another update as I realised I needed to add InstanceTemplates, could I get another review @bowei? Thanks!

[bowei]

I'm getting some build errors with your patch:

pkg/cloud/gen.go:18459:60: too many arguments in call to g.s.GA.InstanceTemplates.Get
	have (string, string, string)
	want (string, string)
pkg/cloud/gen.go:18480:51: too many arguments in call to g.s.GA.InstanceTemplates.List
	have (string, string)
	want (string)
pkg/cloud/gen.go:18528:63: too many arguments in call to g.s.GA.InstanceTemplates.Insert
	have (string, string, *"google.golang.org/api/compute/v1".InstanceTemplate)
	want (string, *"google.golang.org/api/compute/v1".InstanceTemplate)
pkg/cloud/gen.go:18561:63: too many arguments in call to g.s.GA.InstanceTemplates.Delete
	have (string, string, string)
	want (string, string)

[charlie-haley]

I'm getting some build errors with your patch:

pkg/cloud/gen.go:18459:60: too many arguments in call to g.s.GA.InstanceTemplates.Get
	have (string, string, string)
	want (string, string)
pkg/cloud/gen.go:18480:51: too many arguments in call to g.s.GA.InstanceTemplates.List
	have (string, string)
	want (string)
pkg/cloud/gen.go:18528:63: too many arguments in call to g.s.GA.InstanceTemplates.Insert
	have (string, string, *"google.golang.org/api/compute/v1".InstanceTemplate)
	want (string, *"google.golang.org/api/compute/v1".InstanceTemplate)
pkg/cloud/gen.go:18561:63: too many arguments in call to g.s.GA.InstanceTemplates.Delete
	have (string, string, string)
	want (string, string)

Sorry had the wrong keyType specified! Should be all working now

[bowei]

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, charlie-haley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bowei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-prow]

@charlie-haley: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-k8s-cloud-provider-test	11a8da0	link	true	/test pull-k8s-cloud-provider-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[charlie-haley]

/test pull-k8s-cloud-provider-test

[google-oss-prow]

@charlie-haley: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-k8s-cloud-provider-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nsilve]

/retest

[google-oss-prow]

@nsilve: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nsilve]

@charlie-haley do you need any help to progress with that?

[charlie-haley]

@charlie-haley do you need any help to progress with that?

The tests pass locally, it seems like a /retest needs running in the CI which I'm unable to do, only @bowei has permission to do that

[nsilve]

I believe that it would be helpful to resolve the conflicts to make the branch ready to be merged when tests pass.

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[bowei]

This needs to be updated so it's mergeable -- can you ping once that is done?

[charlie-haley]

Should be up to date now @bowei

[harveyxia]

Gentle bump, we've got a downstream dependency on this PR. Thank you for putting this together!

[harveyxia]

Any updates here?

[bowei]

Support has been added. Thanks for your original PR.