Fix klog.V(x) references for klog v2 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @bowei @spencerhance |
13 tasks
|
get it |
|
This is not quite sufficient -- you need to fix references in the code generator. |
Signed-off-by: Davanum Srinivas <[email protected]>
dims
force-pushed
the
fix-klog-boolean-references-for-klog-v2
branch
from
ea3f164 to
1c1934f
Compare
|
@bowei thanks! pulled in your two commits. |
dims
force-pushed
the
fix-klog-boolean-references-for-klog-v2
branch
from
1c1934f to
5bc0e11
Compare
V(x).Enabled() instead of a raw V(x) Signed-off-by: Davanum Srinivas <[email protected]>
dims
force-pushed
the
fix-klog-boolean-references-for-klog-v2
branch
from
5bc0e11 to
07dcba3
Compare
bowei
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
klog.V(x) is no longer a boolean. We need to use the
.Enabled()method