Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert String() change to escaped string #12

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Revert String() change to escaped string #12

merged 1 commit into from
Jun 4, 2019

Conversation

spencerhance
Copy link
Member

@spencerhance spencerhance commented May 21, 2019 •
edited
Loading

Revert one line change from #6 so that the tests pass again.

Fixes #11

@spencerhance
Copy link
Member Author

cc: @rramkumar1

@rramkumar1
Copy link
Contributor

/lgtm

@spencerhance spencerhance mentioned this pull request May 29, 2019
Merged
@bowei bowei merged commit ad0bd61 into GoogleCloudPlatform:master Jun 4, 2019
@spencerhance spencerhance deleted the fix-test-filter-to-string branch June 4, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei approved these changes

Assignees

@bowei bowei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestFilterToString is Failing
3 participants
@spencerhance @rramkumar1 @bowei