Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceLoggingEnhancer.setCurrentTraceId is not in correctly formatted. #243

Closed
bmenasha opened this issue Dec 10, 2018 · 3 comments
Closed

TraceLoggingEnhancer.setCurrentTraceId is not in correctly formatted. #243

bmenasha opened this issue Dec 10, 2018 · 3 comments
Assignees
@gregw

Comments

@bmenasha
Copy link

The class RequestContextScope.java class is not formatting the traceId correctly. According to the javadoc the TraceLoggingEnhancer.setCurrentTraceId expects projects/[PROJECT_ID]/traces/[TRACE_ID], while we are just supplying [TRACE_ID] within https://github.com/GoogleCloudPlatform/jetty-runtime/blob/master/jetty9-base/src/main/java/com/google/cloud/runtimes/jetty9/RequestContextScope.java

This was changed in the logging library with this pull request:

googleapis/google-cloud-java#3301

For more information see this blog post: https://cloud.google.com/blog/products/gcp/viewing-trace-spans-and-request-logs-in-multi-project-deployments

Thanks
@bmenasha bmenasha changed the title traceId is not in correct format. TraceLoggingEnhancer.setCurrentTraceId is not in correct formated. Dec 10, 2018
@bmenasha bmenasha changed the title TraceLoggingEnhancer.setCurrentTraceId is not in correct formated. TraceLoggingEnhancer.setCurrentTraceId is not in correctly formatted. Dec 10, 2018
@gregw gregw self-assigned this Dec 10, 2018
gregw added a commit that referenced this issue Dec 10, 2018
@gregw
Issue #243
ed7ad10 
Updated traceId format for TraceLoggingEnhancer

Signed-off-by: Greg Wilkins <[email protected]>
@bmenasha
Copy link
Author

Thank you very much for the fix Greg!
Do you have any idea when it will be available in the production App Engine Flexible images we deploy?

@gregw gregw mentioned this issue Jan 16, 2019
Merged
gregw added a commit that referenced this issue Jan 16, 2019
@gregw
Issue #243 use API to discover projectId
dabc7cc 
Signed-off-by: Greg Wilkins <[email protected]>
@gregw
Copy link
Contributor

gregw commented Jan 17, 2019

@bmenasha I'm having some issues with testing a custom image, sop hopefully once they are sorted it will be good to go.

gregw added a commit that referenced this issue Mar 1, 2019
@gregw
Issue #243 (#244)
fdb3996 
* Issue #243

Updated traceId format for TraceLoggingEnhancer

Signed-off-by: Greg Wilkins <[email protected]>

* Issue #243 use API to discover projectId

Signed-off-by: Greg Wilkins <[email protected]>
@joakime
Copy link
Contributor

joakime commented Apr 30, 2019

PR #244 has been merged, can this issue be closed?

@gregw gregw closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregw @joakime @bmenasha