Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore updates to MySQL connector. Don't ignore -beta. #51

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Ignore updates to MySQL connector. Don't ignore -beta. #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion versions-rules.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ limitations under the License.
xsi:schemaLocation="http://mojo.codehaus.org/versions-maven-plugin/rule/2.0.0 http://mojo.codehaus.org/versions-maven-plugin/xsd/rule-2.0.0.xsd">
<ignoreVersions>
<ignoreVersion type="regex">.*-alpha.*</ignoreVersion>
<ignoreVersion type="regex">.*-beta.*</ignoreVersion>
<ignoreVersion type="regex">.*-b[0-9]*</ignoreVersion>
<ignoreVersion type="regex">.*-pre.*</ignoreVersion>
<ignoreVersion type="regex">.*public_draft</ignoreVersion>
Expand All @@ -32,6 +31,14 @@ limitations under the License.
<ignoreVersion type="regex">.*</ignoreVersion>
</ignoreVersions>
</rule>
<!-- MySQL connector should not be manually updated.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you mean "automatically updated"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#52

Version 5.x needs to be used for Java 7 support.
https://github.com/GoogleCloudPlatform/java-docs-samples/pull/456#discussion_r92676013 -->
<rule groupId="mysql" artifactId="mysql-connector-java" comparisonMethod="maven">
<ignoreVersions>
<ignoreVersion type="regex">.*</ignoreVersion>
</ignoreVersions>
</rule>
<!-- SendGrid 3 libraries are broken in App Engine standard environment -->
<rule groupId="com.sendgrid" artifactId="sendgrid-java" comparisonMethod="maven">
<ignoreVersions>
Expand All @@ -44,5 +51,23 @@ limitations under the License.
<ignoreVersion type="regex">v2.*</ignoreVersion>
</ignoreVersions>
</rule>
<!-- Ignore beta versions of the App Engine Maven plugin -->
<rule groupId="com.google.cloud.tools" artifactId="appengine-maven-plugin" comparisonMethod="maven">
<ignoreVersions>
<ignoreVersion type="regex">.*-beta.*</ignoreVersion>
</ignoreVersions>
</rule>
<!-- Ignore beta versions of Mockito -->
<rule groupId="org.mockito" artifactId="mockito-all" comparisonMethod="maven">
<ignoreVersions>
<ignoreVersion type="regex">.*-beta.*</ignoreVersion>
</ignoreVersions>
</rule>
<!-- Ignore beta versions of Xmemcached-->
<rule groupId="com.googlecode.xmemcached" artifactId="xmemcached" comparisonMethod="maven">
<ignoreVersions>
<ignoreVersion type="regex">.*-beta.*</ignoreVersion>
</ignoreVersions>
</rule>
</rules>
</ruleset>