Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(endpoints): remove old region tags #9979

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Jan 16, 2025

Description

Delete old region tags
secret-1
service
secret-2

Fixes b/347825448

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@OremGLG OremGLG requested review from yoshi-approver and a team as code owners January 16, 2025 18:58
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, submitted by OremGLG, aims to remove outdated region tags from the endpoints/getting-started/k8s/esp_echo_http.yaml file. The intent is to clean up the file and improve maintainability. This addresses issue b/347825448.

Here's a breakdown of the changes:

  • File Modified: endpoints/getting-started/k8s/esp_echo_http.yaml
  • Changes: The pull request removes several lines containing old region tags, specifically those marked with comments [START secret-1], [END secret-1], [START service], [END service], [START secret-2], and [END secret-2]. These tags were previously used for documentation purposes but are no longer needed.
    • Lines 42-47 were removed from the first change block.
    • Lines 61-62 and 66-71 were removed from the second change block.

The author has indicated that all required tests and lint checks have passed.


A little haiku to lighten the mood:

Tags removed with care,
Code now cleaner, bright, and new,
Review, then merge on!

@product-auto-label product-auto-label bot added api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples. labels Jan 16, 2025
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes redundant region tags, which is good for clarity. The suggested comments improve the readability further. Also, please ensure the checklist items are accurately marked before merging.

Copy link

snippet-bot bot commented Jan 16, 2025

Here is the summary of changes.

You are about to delete 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 16, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 16, 2025
@OremGLG OremGLG merged commit cf29f4a into GoogleCloudPlatform:main Jan 16, 2025
7 checks passed
@OremGLG OremGLG deleted the garciadiaz-migrate-regions-step-2-347825448 branch January 16, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants