-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(endpoints): remove old region tags #9979
fix(endpoints): remove old region tags #9979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request, submitted by OremGLG, aims to remove outdated region tags from the endpoints/getting-started/k8s/esp_echo_http.yaml
file. The intent is to clean up the file and improve maintainability. This addresses issue b/347825448.
Here's a breakdown of the changes:
- File Modified:
endpoints/getting-started/k8s/esp_echo_http.yaml
- Changes: The pull request removes several lines containing old region tags, specifically those marked with comments
[START secret-1]
,[END secret-1]
,[START service]
,[END service]
,[START secret-2]
, and[END secret-2]
. These tags were previously used for documentation purposes but are no longer needed.- Lines 42-47 were removed from the first change block.
- Lines 61-62 and 66-71 were removed from the second change block.
The author has indicated that all required tests and lint checks have passed.
A little haiku to lighten the mood:
Tags removed with care,
Code now cleaner, bright, and new,
Review, then merge on!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR removes redundant region tags, which is good for clarity. The suggested comments improve the readability further. Also, please ensure the checklist items are accurately marked before merging.
Here is the summary of changes. You are about to delete 3 region tags.
This comment is generated by snippet-bot.
|
Description
Delete old region tags
secret-1
service
secret-2
Fixes b/347825448
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only