Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(job): delete unused region tag after migration #9975

Conversation

alarconesparza
Copy link
Contributor

@alarconesparza alarconesparza commented Jan 15, 2025

Description

Fixes
Internal b/389974338

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 15, 2025
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, authored by alarconesparza, aims to delete an unused region tag in the jobs/v3 directory after a migration. The intent is to clean up the codebase and remove redundant or obsolete elements.

Specifically, the changes involve:

  • Removing the // [START auto_complete_job_title] and // [END auto_complete_job_title] tags from AutoCompleteSample.java. These tags appear to be duplicates or no longer necessary.
    • Lines 42 and 63 in AutoCompleteSample.java were modified.

The changes are relatively minor and focused on code cleanup, addressing internal issue b/389974338. The author has included a checklist to ensure that the changes meet the project's standards.

Here's a little haiku to lighten the mood:

Unused tags removed,
Code now cleaner, bright, and new,
Joy in simple fix.

Thanks,
Gemini

@product-auto-label product-auto-label bot added the api: jobs Issues related to the Cloud Talent Solution Job Search API. label Jan 15, 2025
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes a duplicated region tag. The change is small and straightforward. The checklist is mostly complete, but some items need attention.

@alarconesparza alarconesparza marked this pull request as ready for review January 15, 2025 17:39
@alarconesparza alarconesparza requested review from yoshi-approver and a team as code owners January 15, 2025 17:40
Copy link

snippet-bot bot commented Jan 15, 2025

Here is the summary of possible violations 😱

There is a possible violation for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@iennae iennae added the snippet-bot:force-run Force snippet-bot runs its logic label Jan 16, 2025
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jan 16, 2025
@alarconesparza alarconesparza marked this pull request as draft January 17, 2025 21:03
@alarconesparza alarconesparza marked this pull request as ready for review January 17, 2025 21:03
@alarconesparza alarconesparza added the snippet-bot:force-run Force snippet-bot runs its logic label Jan 17, 2025
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jan 17, 2025
@glasnt
Copy link
Contributor

glasnt commented Jan 20, 2025

snippetbot issues related to cl/648955387

@glasnt glasnt merged commit 8622af1 into GoogleCloudPlatform:main Jan 20, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: jobs Issues related to the Cloud Talent Solution Job Search API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants